Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

await openEditorAtIndex1 command #2442

Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions src/cmd_line/commands/tab.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ export class TabCommand extends node.CommandBase {
switch (this._arguments.tab) {
case Tab.Next:
if (this._arguments.count /** not undefined or 0 */) {
// do not await workbench.action.openEditorAtIndex1 because it will never resolve
vscode.commands.executeCommand('workbench.action.openEditorAtIndex1');
await vscode.commands.executeCommand('workbench.action.openEditorAtIndex1');
await this.executeCommandWithCount(
this._arguments.count! - 1,
'workbench.action.nextEditorInGroup'
Expand All @@ -68,8 +67,7 @@ export class TabCommand extends node.CommandBase {
);
break;
case Tab.First:
// do not await workbench.action.openEditorAtIndex1 because it will never resolve
vscode.commands.executeCommand('workbench.action.openEditorAtIndex1');
await vscode.commands.executeCommand('workbench.action.openEditorAtIndex1');
break;
case Tab.Last:
await vscode.commands.executeCommand('workbench.action.openLastEditorInGroup');
Expand Down