await openEditorAtIndex1 command #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there was a bug in VSCode which prevented me from doing:
```
await
vscode.commands.executeCommand('workbench.action.openEditorAtIndex1')
```
The most recent release of VSCode (1.21.0) fixes the bug. See
microsoft/vscode#44636
|
Awesome. Thanks for the follow-up @arussellk. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously there was a bug in VSCode which prevented me from doing:
The most recent release of VSCode (1.21.0) fixes the bug. See
microsoft/vscode#44636
What this PR does / why we need it:
This PR ties up a loose end because the latest VSCode release fixed a bug.
Which issue(s) this PR fixes
No specific issue though I mentioned this in #2400 (comment)
Special notes for your reviewer:
This change will impact users who use
:tabnor:tabfirstbut do not have the latest version of VSCode. For such users,:tabnor:tabfirstwill cause the command line (:) to be disabled until VSCodeVim is restarted. What is VSCodeVim's policy on breaking changes (albeit limited) like this?