Fix #2148: vertical split command #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix the vertical split commands, which were broken when the logic for the showOpenDialog command was added by PR VSCodeVim#2067.
Add unit tests for both :vs and :vsp commands. These tests are heavily based on the writequit.test.
jpoon
reviewed
Nov 18, 2017
test/cmd_line/vsplit.test.ts
Outdated
|
|
||
| let pollCount = 0; | ||
| // TODO: the visibleTextEditors variable doesn't seem to be | ||
| // up to date after a onDidChangeActiveTextEditor event, not |
There was a problem hiding this comment.
I think you want the onDidChangeVisibleTextEditors event here
jpoon
reviewed
Nov 18, 2017
test/cmd_line/vsplit.test.ts
Outdated
| import * as assert from 'assert'; | ||
| import { getAndUpdateModeHandler } from '../../extension'; | ||
|
|
||
| async function WaitForEditorOpen(): Promise<void> { |
There was a problem hiding this comment.
Consider making this function a bit more generic. Maybe accept an "expectedEditorOpen" param.
The vertical split tests were formerly polling the window, waiting for the number of text editors to change. This is now triggered based on the vscode.window.onDidChangeVisibleTextEditors event. Also, a setup/teardown bug was fixed so the setup and teardown is performed for each test, not once for the suite.
jpoon
approved these changes
Nov 18, 2017
test/cmd_line/vsplit.test.ts
Outdated
| * | ||
| * @param numEditors Expected number of editors in the window | ||
| */ | ||
| async function WaitForEditors(numEditors: number): Promise<void> { |
There was a problem hiding this comment.
Can you move this to testUtils? There's probably value in sharing it with other test classes.
|
Thanks @westim |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the vertical split command, which was a regression caused by PR #2067.
I have added unit tests for the
:vsand:vspcommands.