added showOpenDialog when typing emtpy e
#2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
when you do |
|
Ah yes you can update the typings in package.json I think here https://github.com/VSCodeVim/Vim/blob/master/package.json#L27 |
jpoon
reviewed
Oct 13, 2017
src/cmd_line/commands/file.ts
Outdated
| } | ||
| const fileList = await vscode.window.showOpenDialog({}); | ||
| await vscode.commands.executeCommand( | ||
| 'vscode.open', |
There was a problem hiding this comment.
DanEEStar
force-pushed
the
feature/file-open-with-e
branch
from
4b76bf3
to
19c6abc
Compare
|
update after @jpoon comment |
|
@DanEEStar Looks like it's good to go? |
|
Thanks again @DanEEStar ! |
westim
added a commit
to westim/Vim
that referenced
this pull request
Nov 18, 2017
Fix the vertical split commands, which were broken when the logic for the showOpenDialog command was added by PR VSCodeVim#2067.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1877
I could test this commit on my local machine and it works.
But the
gulp watchtask always complains:Do I have to update the typings somehow?
How could I do that?