Ctrl-C should copy to clipboard in visual mode - fix for #1896

[philipmat]

When yanking to clipboard, the selection should also reset to normal

[philipmat]

I'll look into the failing tests shortly.

[Chillee]

You might already know this (I didn't know this when I first started contributing), but you can run only a select few tests using newTestOnly.

If you have any questions about anything, feel free to drop by our slack :)

[Chillee]

Ah I've been wondering what that failing test was caused by (which was why I wasn't merging). It's caused by an upstream change (more specifically, this PR: microsoft/vscode#28238).

I'm fine with merging this and then fixing that upstream change (eventually).

[philipmat]

Submitted PR #1926 to fix the tests.
Hopefully, if that passes and gets merged to master before all these other PRs, it should fix them too.

[ferrao]

@philipmat Why do you say that When yanking to clipboard, the selection should also reset to normal?

All other IDEs that I use do not clear the visual selection mode when I press CTRL-C.
This behaviour is actually very annoying to me and gets in the way of my workflow.
Is there any option to control this?

[ferrao]

@philipmat Just found that vim.overrideCopy: false does the trick! I'm happy now!

[philipmat]

@ferrao - in Vim itself - i.e. canon, if you select text and yank it (by either y or Ctrl-C) the mode switches back to Normal from Visual (or Select).

[ferrao]

@philipmat Sorry I meant Cmd-C and not Ctrl-C. I am actually on a Mac and Cmd-C/Cmd-v does nothing on Vim, allowing me to have two different ways of copying and pasting text around.

With vim.overrideCopy: true I loose that. But I am happy to have this option, It allows me tu use visual select, then Cmd-C to copy, then do something to the visual selection with vim and paste the original copy somewhere else with Cmd-V.

I guess I could do the same with registers, but old habits die hard...