Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl-C in Visual Mode should copy to clipboard #1896

Closed
philipmat opened this issue Jul 2, 2017 · 2 comments
Closed

Ctrl-C in Visual Mode should copy to clipboard #1896

philipmat opened this issue Jul 2, 2017 · 2 comments

Comments

@philipmat
Copy link
Contributor

  • Click thumbs-up 👍 on this issue if you want it!
  • Click confused 😕 on this issue if not having it makes VSCodeVim unusable.

The VSCodeVim team prioritizes issues based on reaction count.

The default behavior of gVim on Windows is to copy the selected text when using Ctrl-C. Effectively:

vnoremap <C-C> "+y

Could we please get the same behavior in VSCodeVim?

Note that:

  1. Ctrl-C behavior in insert mode is correct (takes you out of insert mode)
  2. On MacOS Cmd-C behaves as intended, that is it copies the selected text to +.

Environment:

  • VSCode Version: 1.13.1
  • VsCodeVim Version: 0.9.0
  • OS: Windows 10

What happened:

Selected text in visual mode then pressed Ctrl-C.

What did you expect to happen:

Selected text to be copied to the + register and with "vim.useSystemClipboard": true to be in the system clipboard as well.

How to reproduce it:

  • Select text in visual mode
  • Press Ctrl-C
  • Execute :reg and notice that the previously selected text is not in the + register.
philipmat pushed a commit to philipmat/Vim that referenced this issue Jul 9, 2017
Ctrl-C should copy to clipboard in visual mode - fix for VSCodeVim#1896
0a6021a 
When yanking to clipboard, the selection should also reset to normal
philipmat pushed a commit to philipmat/Vim that referenced this issue Jul 9, 2017
Ctrl-C should copy to clipboard in visual mode - fix for VSCodeVim#1896
a66a916 
When yanking to clipboard, the selection should also reset to normal
Chillee pushed a commit that referenced this issue Jul 17, 2017
@Chillee
Ctrl-C should copy to clipboard in visual mode - fix for #1896
0082cc5 
When yanking to clipboard, the selection should also reset to normal
@jpoon
Copy link
Member

jpoon commented Nov 15, 2017 •
edited
Loading

Apparently fixed as of v0.10.0. Not sure why GH failed to close the issue after the commit got merged. Please re-open if that is not the case.

@jpoon jpoon closed this as completed Nov 15, 2017
@cyfyifanchen
Copy link

Anyone is aware of #3229?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpoon @philipmat @cyfyifanchen