Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1436: extension prevents 'find all references' pop-up from closing through <esc> if it's empty. #1707

Merged
merged 4 commits into from
May 20, 2017
Merged

Fixes #1436: extension prevents 'find all references' pop-up from closing through <esc> if it's empty. #1707

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f534ce5
Fixes #1436
Chillee May 17, 2017
1e8dab5
removed unnecessary api call
Chillee May 17, 2017
d85ba41
Merge branch 'master' into 1436
xconverge May 18, 2017
5440300
Merge branch 'master' into 1436
Chillee May 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/actions/commands/actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,10 @@ class CommandEsc extends BaseCommand {

public async exec(position: Position, vimState: VimState): Promise<VimState> {
if (vimState.currentMode === ModeName.Normal && !vimState.isMultiCursor) {
// If there's nothing to do on the vim side, we might as well call some
// of vscode's default "close notification" actions. I think we should
// just add to this list as needed.
await vscode.commands.executeCommand('closeReferenceSearchEditor');
return vimState;
}

Expand Down