Fixes #1436: extension prevents 'find all references' pop-up from closing through <esc> if it's empty. #1707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
do we need to await even? up to others, I think this is fine with me |
|
I honestly don't know. In general, the executeCommand is asynchronous, and it just seemed safer to me to just await the results. |
|
Alright I think this is good to go. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So pretty much the issue is that here, because nothing pops up, vscode doesn't think we're in the "find all references" context, and lets vscodevim capture keystrokes again.
Thus, all we need to is call API calls that close stuff when the user presses
<Esc>in normal mode. Doesn't seem to have any performance impact, and fixes an annoyance.