Skip to content

Docker: ベースイメージのタグ名をコードネームからバージョン番号に変更する#517

Merged
Hiroshiba merged 2 commits intoVOICEVOX:masterfrom
aoirint:patch-docker-ubuntu-version-numeric
Dec 4, 2022
Merged

Docker: ベースイメージのタグ名をコードネームからバージョン番号に変更する#517
Hiroshiba merged 2 commits intoVOICEVOX:masterfrom
aoirint:patch-docker-ubuntu-version-numeric

Conversation

@aoirint
Copy link
Copy Markdown
Member

@aoirint aoirint commented Dec 3, 2022

内容

実質的には何も変更しないPRですが、今後DockerイメージのUbuntuバージョンを上げるときにわかりやすくなります。

以下の置換を行います。

  • ubuntu:bionic -> ubuntu:18.04
  • ubuntu:focal -> ubuntu:20.04

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 3, 2022

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 1 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 75 0 coverage-100%
voicevox_engine/dev/synthesis_engine/init.py 2 0 coverage-100%
voicevox_engine/dev/synthesis_engine/mock.py 36 2 coverage-94%
voicevox_engine/full_context_label.py 162 3 coverage-98%
voicevox_engine/kana_parser.py 86 1 coverage-99%
voicevox_engine/model.py 154 7 coverage-95%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/part_of_speech_data.py 5 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/core_wrapper.py 206 166 coverage-19%
voicevox_engine/synthesis_engine/make_synthesis_engines.py 57 49 coverage-14%
voicevox_engine/synthesis_engine/synthesis_engine.py 133 12 coverage-91%
voicevox_engine/synthesis_engine/synthesis_engine_base.py 67 9 coverage-87%
voicevox_engine/user_dict.py 129 6 coverage-95%
voicevox_engine/utility/init.py 3 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 37 0 coverage-100%
voicevox_engine/utility/path_utility.py 26 6 coverage-77%
TOTAL 1237 262 coverage-79%

Copy link
Copy Markdown
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

わかりやすくなるので良いと感じました!

@aoirint
Copy link
Copy Markdown
Member Author

aoirint commented Dec 4, 2022

で削除した行を変更することによるコンフリクトを、#520 で削除した行を削除することによって解消しました。

@Hiroshiba
Copy link
Copy Markdown
Member

mainのマージありがとうございます!
問題ないと思うのでマージしたいと思います!

@Hiroshiba Hiroshiba merged commit a6fff78 into VOICEVOX:master Dec 4, 2022
@aoirint aoirint deleted the patch-docker-ubuntu-version-numeric branch December 4, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants