Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HorizontalCell): use max-width for size="m" #6318

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

inomdzhon
Copy link
Contributor

@inomdzhon inomdzhon commented Dec 20, 2023

Описание

При <HorizontalCell size="m" /> зашивалась ширина, в отличии от <HorizontalCell size="s" />.

При `<HorizontalCell size="m" />` зашивалась ширина, в отличии от `<HorizontalCell size="s" />`.
@inomdzhon inomdzhon added this to the v6 milestone Dec 20, 2023
@inomdzhon inomdzhon self-assigned this Dec 20, 2023
@inomdzhon inomdzhon requested a review from a team as a code owner December 20, 2023 07:42
Copy link
Contributor

size-limit report 📦

Path Size
JS 347.43 KB (0%)
JS (gzip) 106.16 KB (0%)
JS (brotli) 87.59 KB (0%)
JS import Div (tree shaking) 1.43 KB (0%)
CSS 258.03 KB (-0.02% 🔽)
CSS (gzip) 33.66 KB (-0.01% 🔽)
CSS (brotli) 27.35 KB (-0.04% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c77ee38:

Sandbox Source
VKUI TypeScript Configuration

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit c77ee38

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4a35b1a) 81.56% compared to head (c77ee38) 81.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6318   +/-   ##
=======================================
  Coverage   81.56%   81.56%           
=======================================
  Files         324      324           
  Lines       10087    10087           
  Branches     3379     3379           
=======================================
  Hits         8227     8227           
  Misses       1860     1860           
Flag Coverage Δ
unittests 81.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon merged commit 22bf600 into master Dec 21, 2023
27 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/fix/HorizontalCell-size-m branch December 21, 2023 12:09
@vkcom-publisher
Copy link
Contributor

v6.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants