Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HorizontalCell: updated paddings and now they're applied to content #1316

Merged
merged 2 commits into from
Jan 21, 2021
Merged

HorizontalCell: updated paddings and now they're applied to content #1316

merged 2 commits into from
Jan 21, 2021

Conversation

gbowsky
Copy link
Contributor

@gbowsky gbowsky commented Jan 21, 2021

Обновлены паддинги у HorizontalCell, они применяются нижнему контенту.
image

fixes #1173

@gbowsky gbowsky requested a review from a team as a code owner January 21, 2021 13:55
@github-actions
Copy link
Contributor

👀 Styleguide deployed

See the styleguide for this PR at https://vkcom.github.io/VKUI/pull/1316/

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2021 •
edited
Loading

Messages
📖 Code coverage: 1562 / 3359 lines (46.5%), 1579 / 3434 statements (45.98%), 353 / 783 functions (45.08%), 801 / 2538 branches (31.56%)

Generated by 🚫 dangerJS against ccaf479

@github-actions
Copy link
Contributor

github-actions bot commented Jan 21, 2021 •
edited
Loading

size-limit report 📦

Path Size
JS 44.71 KB (0%)
JS, unstable 6.22 KB (0%)
CSS 26.18 KB (0%)
CSS, unstable 475 B (0%)

@wayshev
Copy link

wayshev commented Jan 21, 2021

Design Review:

Паддинги ок, но на айос размер аватарок не по макету, должен быть 64, не 56 (возможно и раньше так было, а я упустил) — https://www.figma.com/file/kvjzdHwTDO7Vcrh1VglGQ5/VKUI-iOS-Library?node-id=4006%3A61070
Screenshot 2021-01-21 at 17 35 29

@gbowsky
Copy link
Contributor Author

gbowsky commented Jan 21, 2021

@wayshev, учёл данный момент и обыграл его в стайлгайде.

@ArthurStam ArthurStam merged commit 313ba17 into master Jan 21, 2021
@ArthurStam ArthurStam deleted the VKUI-122 branch January 21, 2021 18:25
@inomdzhon inomdzhon mentioned this pull request Dec 20, 2023
Merged
inomdzhon added a commit that referenced this pull request Dec 21, 2023
@inomdzhon
fix(HorizontalCell): use max-width for size="m" (#6318)
22bf600 
При `<HorizontalCell size="m" />` зашивалась ширина, в отличии от `<HorizontalCell size="s" />`.

- related to #1316 – в этом PR добавили `max-width` только для `size="s"`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArthurStam ArthurStam ArthurStam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Отступы в HorizontallCell
3 participants
@gbowsky @wayshev @ArthurStam