-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ModalRoot): add modalOverlayTestId #6052
feat(ModalRoot): add modalOverlayTestId #6052
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 94208b0:
|
6e57486
to
94208b0
Compare
e2e tests |
👀 Docs deployed
Commit 94208b0 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6052 +/- ##
=======================================
Coverage 79.23% 79.23%
=======================================
Files 305 305
Lines 9596 9596
Branches 3245 3245
=======================================
Hits 7603 7603
Misses 1993 1993
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Кажется, что #6051 тоже здорово было бы оставить.
По клику на оверлей вызывается onExit
в ModalRoot
, а в ModalPage/ModalCard
по клику на DismissButton onClose
.
✅ v5.10.0 🎉 |
Описание
Добавляем
modalOverlayTestId
для ModalRoot