Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ModalRoot): add modalOverlayTestId #6052

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Oct 26, 2023

  • Unit-тесты
  • Документация фичи

Описание

Добавляем modalOverlayTestId для ModalRoot

@SevereCloud SevereCloud requested a review from a team as a code owner October 26, 2023 10:15
@SevereCloud SevereCloud self-assigned this Oct 26, 2023
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Oct 26, 2023
@SevereCloud SevereCloud added type:feature cmp:modal and removed v5 Автоматизация: PR продублируется в ветку v5 labels Oct 26, 2023
@SevereCloud SevereCloud added this to the v5.10.0 milestone Oct 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

size-limit report 📦

Path Size
JS 331.61 KB (+0.03% 🔺)
JS (gzip) 101.33 KB (+0.03% 🔺)
JS (brotli) 83.64 KB (+0.09% 🔺)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 255.14 KB (0%)
CSS (gzip) 33.55 KB (0%)
CSS (brotli) 27.21 KB (0%)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 26, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 94208b0:

Sandbox Source
VKUI TypeScript Configuration

@SevereCloud SevereCloud force-pushed the SevereCloud/feat/ModalRoot/add-modalMaskTestId branch from 6e57486 to 94208b0 Compare October 26, 2023 10:22
@SevereCloud SevereCloud changed the title feat(ModalRoot): add modalMaskTestId feat(ModalRoot): add modalOverlayTestId Oct 26, 2023
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Oct 26, 2023
@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

👀 Docs deployed

Commit 94208b0

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b32712f) 79.23% compared to head (94208b0) 79.23%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6052   +/-   ##
=======================================
  Coverage   79.23%   79.23%           
=======================================
  Files         305      305           
  Lines        9596     9596           
  Branches     3245     3245           
=======================================
  Hits         7603     7603           
  Misses       1993     1993           
Flag Coverage Δ
unittests 79.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/vkui/src/components/ModalRoot/ModalRoot.tsx 53.48% <100.00%> (ø)
...vkui/src/components/ModalRoot/ModalRootDesktop.tsx 95.04% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Кажется, что #6051 тоже здорово было бы оставить.
По клику на оверлей вызывается onExit в ModalRoot, а в ModalPage/ModalCard по клику на DismissButton onClose.

@SevereCloud SevereCloud merged commit d1f16fc into master Oct 26, 2023
@SevereCloud SevereCloud deleted the SevereCloud/feat/ModalRoot/add-modalMaskTestId branch October 26, 2023 13:20
@vkcom-publisher
Copy link
Contributor

v5.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:modal type:feature v5 Автоматизация: PR продублируется в ветку v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants