-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(modal): add modalDismissButtonTestId #6051
feat(modal): add modalDismissButtonTestId #6051
Conversation
size-limit report 📦
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6ef2ba2:
|
e2e tests |
👀 Docs deployed
Commit 6ef2ba2 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6051 +/- ##
==========================================
+ Coverage 79.23% 79.35% +0.12%
==========================================
Files 305 305
Lines 9596 9664 +68
Branches 3245 3290 +45
==========================================
+ Hits 7603 7669 +66
- Misses 1993 1995 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Спасибо! 🔥
✅ v5.10.0 🎉 |
[ ] e2e-тесты[ ] Дизайн-ревьюОписание
Добавляем свойство
modalDismissButtonTestId
для ModalCard и ModalPageИзменения
Новое свойство
modalDismissButtonTestId
для ModalCard и ModalPage которое прокидывается в кнопку закрытия