Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add modalDismissButtonTestId #6051

Merged

Conversation

SevereCloud
Copy link
Contributor

  • Unit-тесты
  • [ ] e2e-тесты
  • [ ] Дизайн-ревью
  • Документация фичи

Описание

Добавляем свойство modalDismissButtonTestId для ModalCard и ModalPage

Изменения

Новое свойство modalDismissButtonTestId для ModalCard и ModalPage которое прокидывается в кнопку закрытия

@SevereCloud SevereCloud requested a review from a team as a code owner October 26, 2023 09:53
@SevereCloud SevereCloud self-assigned this Oct 26, 2023
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Oct 26, 2023
@SevereCloud SevereCloud added cmp:modal type:feature and removed v5 Автоматизация: PR продублируется в ветку v5 labels Oct 26, 2023
@SevereCloud SevereCloud added this to the v5.10.0 milestone Oct 26, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

size-limit report 📦

Path Size
JS 331.78 KB (+0.05% 🔺)
JS (gzip) 101.37 KB (+0.03% 🔺)
JS (brotli) 83.66 KB (+0.07% 🔺)
JS import Div (tree shaking) 2.71 KB (0%)
CSS 255.14 KB (0%)
CSS (gzip) 33.55 KB (0%)
CSS (brotli) 27.21 KB (0%)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6ef2ba2:

Sandbox Source
VKUI TypeScript Configuration

@github-actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions
Copy link
Contributor

github-actions bot commented Oct 26, 2023

👀 Docs deployed

Commit 6ef2ba2

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b32712f) 79.23% compared to head (6ef2ba2) 79.35%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6051      +/-   ##
==========================================
+ Coverage   79.23%   79.35%   +0.12%     
==========================================
  Files         305      305              
  Lines        9596     9664      +68     
  Branches     3245     3290      +45     
==========================================
+ Hits         7603     7669      +66     
- Misses       1993     1995       +2     
Flag Coverage Δ
unittests 79.35% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ckages/vkui/src/components/ModalCard/ModalCard.tsx 95.65% <ø> (ø)
...kui/src/components/ModalCardBase/ModalCardBase.tsx 91.66% <100.00%> (+0.23%) ⬆️
...ckages/vkui/src/components/ModalPage/ModalPage.tsx 97.72% <100.00%> (+0.05%) ⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud
Copy link
Contributor Author

@SevereCloud SevereCloud reopened this Oct 26, 2023
@github-actions github-actions bot added the v5 Автоматизация: PR продублируется в ветку v5 label Oct 26, 2023
Copy link
Contributor

@mendrew mendrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо! 🔥

@SevereCloud SevereCloud merged commit 2a84771 into master Oct 26, 2023
@SevereCloud SevereCloud deleted the SevereCloud/feat/modal/add-modalDismissButtonTestId branch October 26, 2023 18:31
@vkcom-publisher
Copy link
Contributor

v5.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp:modal type:feature v5 Автоматизация: PR продублируется в ветку v5
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants