Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use eda subsetting as a wdk search parameter #1314

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

Conversation

dmfalke
Copy link
Member

@dmfalke dmfalke commented Jan 22, 2025

fixes #1311

This PR introduces the use of EDA subsetting for a WDK search parameter. In this particular implementation, we are using a WDK stringParam and using a custom React component (EdaSubsettingParameter) to integrate EDA subsetting.

This required extracting analysis modification code from the useAnalysis hook, to prevent synchronization issues related to managing state.


TODOs

  • Extract useAnalysisState hook from useAnalysis
  • Hide starred variable UI
  • Extract EDA Workspace context provisioning
  • Use global memoization for client api modules
  • Figure out how to find the correct output entity for subsetting

Copy link
Member

@bobular bobular left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and understood the big picture of extracting useAnalysisState() from useAnalysis() 😄

@dmfalke
Copy link
Member Author

dmfalke commented Feb 6, 2025

Reviewed and understood the big picture of extracting useAnalysisState() from useAnalysis() 😄

Thanks! Happy to answer any questions.

@dmfalke
Copy link
Member Author

dmfalke commented Feb 6, 2025

@asizemore I just pushed some commits that uses an eda scatterplot in the phenotype section of gene pages.

I am testing it with a local genomics-site dev server.

In packages/sites/genomics-site/.env:

BASE_PROXY_URL=https://qa.toxodb.org
LEGACY_WEB_APP_URL=${BASE_PROXY_URL}/toxo
PROJECT_ID=ToxoDB

Run yarn nx start @veupathdb/genomics-site and navigate to http://localhost:8080/a/app/record/gene/TGGT1_261490#category:phenomics.

Let me know if you have questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WDK Search - Add an EDAParameter type
2 participants