Keep setters stable, wrt analysis object

VEuPathDB · Feb 3, 2025 · 65afb12 · 65afb12
1 parent a5a9fda
commit 65afb12
Showing 1 changed file with 12 additions and 5 deletions.
diff --git a/packages/libs/eda/src/lib/core/hooks/analysis.ts b/packages/libs/eda/src/lib/core/hooks/analysis.ts
@@ -750,13 +750,20 @@ function useSetter<T>(
   onAnalysisChange: AnalysisChangeHandler,
   skipServerCreate = false
 ) {
+  const analysisRef = useRef(analysis);
+  useEffect(() => {
+    analysisRef.current = analysis;
+  });
   return useCallback(
     (nestedValue: T | ((nestedValue: T) => T)) => {
-      if (analysis == null) return; // TODO Should this throw an error?
-      onAnalysisChange(updateAnalysis(analysis, nestedValueLens, nestedValue), {
-        skipServerCreate,
-      });
+      if (analysisRef.current == null) return; // TODO Should this throw an error?
+      onAnalysisChange(
+        updateAnalysis(analysisRef.current, nestedValueLens, nestedValue),
+        {
+          skipServerCreate,
+        }
+      );
     },
-    [analysis, nestedValueLens, onAnalysisChange, skipServerCreate]
+    [nestedValueLens, onAnalysisChange, skipServerCreate]
   );
 }