added PlaceSortingGroup to PlaceParamStructure #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ue71603
reviewed
Dec 16, 2022
herlitze
commented
Dec 16, 2022
ue71603
requested review from
sgrossberndt,
AndreasAtSBB,
skinkie and
trurlurl
ue71603
previously approved these changes
Dec 16, 2022
sgrossberndt
previously requested changes
Dec 16, 2022
ue71603
reviewed
Dec 17, 2022
Co-authored-by: Malte Herlitze <[email protected]>
ue71603
force-pushed
the
sorting-lir-results
branch
from
39ade75 to
786b3c6
Compare
AndreasAtSBB
previously approved these changes
Dec 23, 2022
AndreasAtSBB
previously approved these changes
Jan 16, 2023
|
Looks fine too me. |
trurlurl
previously approved these changes
Jan 16, 2023
ue71603
previously approved these changes
Jan 17, 2023
sgrossberndt
force-pushed
the
changes_for_v1.1
branch
from
0f6cda8 to
0e21b03
Compare
# Conflicts: # docs/generated/index.html
skinkie
dismissed stale reviews from ue71603, trurlurl, and AndreasAtSBB
via
3346952
skinkie
approved these changes
Jan 19, 2023
ue71603
approved these changes
Jan 19, 2023
ue71603
added a commit
that referenced
this pull request
Jan 19, 2023
commit cf663d0 Author: Matthias Günter <[email protected]> Date: Thu Jan 19 17:10:00 2023 +0100 Necessary low level elements for User Preferences (#271) * Necessary low level elements for User Preferences No UserPreference for the time being. New optimisation methods, walking and cycling profile and includeAlternativeOptions all for Trips commit 079b6c7 Author: Malte Herlitze <[email protected]> Date: Thu Jan 19 17:05:39 2023 +0100 added PlaceSortingGroup to PlaceParamStructure (#281) * added PlaceSortingGroup to PlaceParamStructure * Update OJP/OJP_Places.xsd * problem message for unsupported sorting method Co-authored-by: Matthias Günter <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stephan Großberndt <[email protected]> Co-authored-by: Stefan de Konink <[email protected]> Co-authored-by: Malte Herlitze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.