Necessary low level elements for User Preferences #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ue71603
requested review from
skinkie,
Aurige,
herlitze,
trurlurl and
markus-meier-sbb
Aurige
reviewed
Dec 14, 2022
skinkie
reviewed
Dec 15, 2022
ue71603
commented
Dec 15, 2022
skinkie
reviewed
Dec 15, 2022
No UserPreference for the time being. New optimisation methods, walking and cycling profile and includeAlternativeOptions all for Trips
ue71603
force-pushed
the
User_Preferences_2
branch
from
fdde213 to
aa64ebf
Compare
multiple OptimisationMethods with wrapper Improved docu for some points removed normal from descriptions of cycling improved description of hiking
…o User_Preferences_2
herlitze
reviewed
Dec 20, 2022
| </xs:element> | ||
| <xs:choice> | ||
| <xs:element name="OptimisationMethod" type="OptimisationMethodEnumeration"/> | ||
| <xs:element name="OptimisationMethods" type="OptimisationMethodList" minOccurs="0"> |
There was a problem hiding this comment.
The possibility to pass several OptimisationMethods is a major change in my opinion.
The annotations of the other new OptimisationMethods (e. g. https://github.com/VDVde/OJP/pull/223/files) state the following:
"If multiple optimisation methods are needed, then several requests should be performed in parallel."
I guess we should discuss the expected impact on the basis of some use cases.
sgrossberndt
force-pushed
the
changes_for_v1.1
branch
from
0f6cda8 to
0e21b03
Compare
# Conflicts: # docs/generated/index.html
ue71603
added a commit
that referenced
this pull request
Jan 19, 2023
commit cf663d0 Author: Matthias Günter <[email protected]> Date: Thu Jan 19 17:10:00 2023 +0100 Necessary low level elements for User Preferences (#271) * Necessary low level elements for User Preferences No UserPreference for the time being. New optimisation methods, walking and cycling profile and includeAlternativeOptions all for Trips commit 079b6c7 Author: Malte Herlitze <[email protected]> Date: Thu Jan 19 17:05:39 2023 +0100 added PlaceSortingGroup to PlaceParamStructure (#281) * added PlaceSortingGroup to PlaceParamStructure * Update OJP/OJP_Places.xsd * problem message for unsupported sorting method Co-authored-by: Matthias Günter <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Stephan Großberndt <[email protected]> Co-authored-by: Stefan de Konink <[email protected]> Co-authored-by: Malte Herlitze <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseeds: https://github.com/VDVde/OJP/pull/221/files
For Trips
Documentation chapter 5.4. https://vdvde.sharepoint.com/sites/CENTC278WG3SG8OJP/Freigegebene%20Dokumente/General/Version_2.0/210713-OJP-64_e_stm-2.0_work.docx?web=1