IL2CPP debugger fixes for working with Unity players #772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
commented
Dec 21, 2017
ghost
commented
- Ignoring setp_out sequence points when searching for sequence points that don't correspond to step_out requests.
- Not returning step_out sequence points when retrieving method debug info. The step out sequence points have the same offset as other sequence points, but different line numbers.
- Hardened the il2cpp_mono_free_method_signatures() function against multiple calls by setting the method_signatures hash table to null after it is cleared.
- The isActive field in Il2CppSequencePoint should be a uint8_t, not a bool, as it gets incremented. I think this change was made in the previous C-only type for this struct but not propagated to the C++ version, which is the only version we use now.
* Ignoring setp_out sequence points when searching for sequence points that don't correspond to step_out requests. * Not returning step_out sequence points when retrieving method debug info. The step out sequence points have the same offset as other sequence points, but different line numbers. * Hardened the il2cpp_mono_free_method_signatures() function against multiple calls by setting the method_signatures hash table to null after it is cleared. * The isActive field in Il2CppSequencePoint should be a uint8_t, not a bool, as it gets incremented. I think this change was made in the previous C-only type for this struct but not propagated to the C++ version, which is the only version we use now.
ghost
requested review from
mderoy
approved these changes
Jan 2, 2018
joncham
approved these changes
Jan 2, 2018
joncham
reviewed
Jan 2, 2018
mono/mini/debugger-agent.c
Outdated
| @@ -12046,10 +12071,10 @@ unity_process_breakpoint_inner(DebuggerTlsData *tls, gboolean from_signal, Il2Cp | |||
| inst = (BreakpointInstance *)g_ptr_array_index(bp->children, j); | |||
| if (inst->il_offset == sequencePoint->ilOffset) { | |||
| if (bp->req->event_kind == EVENT_KIND_STEP) { | |||
| for (int j = 0; j < bp->children->len; ++j) | |||
| for (int k = 0; j < bp->children->len; ++k) | |||
There was a problem hiding this comment.
Grrr, I mean k < bp->children->len
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.