fix: collections not detecting deltas backport to v1.x.x #3005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
changed the title
samlucas-unity
approved these changes
Aug 13, 2024
| // check write permissions | ||
| if (!CanClientWrite(m_NetworkBehaviour.NetworkManager.LocalClientId)) | ||
| { | ||
| throw new InvalidOperationException("Client is not allowed to write to this NetworkList"); |
There was a problem hiding this comment.
Just curious how come all of these exceptions have been removed?
There was a problem hiding this comment.
Been making it a point to swap out throwing exceptions with just logging errors when I run across areas where an exception is a bit harsh for the issue (if it wouldn't normally cause some form of exception then there is no point in interrupting the call stack for some form of improper usage or the like). Also wanted the permissions error to be unified for both NetworkVariable and NetworkList. 👍
|
|
||
| - Fixed issue using collections within `NetworkVariable` where the collection would not detect changes to items or nested items. (#3005) | ||
| - Fixed issue where `List`, `Dictionary`, and `HashSet` collections would not uniquely duplicate nested collections. (#3005) | ||
| - Fixed Issue where a state with dual triggers, inbound and outbound, could cause a false layer to layer state transition message to be sent to non-authority `NetworkAnimator` instances and cause a warning message to be logged. (#2999) |
There was a problem hiding this comment.
These were missed changelog entries: 2999 and 2992. They are not in this PR.
NoelStephensUnity
deleted the
fix/managed-collections-not-detecting-deltas-backport-v1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3004
When using collections with NetworkVariable, it would only detect a completely new assignment of a collection but would not detect a change to an already assigned collection (add, remove, insert, clear) nor was there a convenient way to check if a collection or the values of its items/elements were dirty.
(Requires a backport to NGO v1.x.x)
MTTB-305
MTTB-308
fix: #2993
Changelog
NetworkVariable.CheckDirtyStatethat is to be used in tandem with collections in order to detect whether the collection or an item within the collection has changed.NetworkVariablewhere the collection would not detect changes to items or nested items.List,Dictionary, andHashSetcollections would not uniquely duplicate nested collections.NetworkListto exiting early with a logged error that is now a unified permissions message withinNetworkVariableBase.NetworkVariable.Valueto exiting early with a logged error that is now a unified permissions message withinNetworkVariableBase.Testing and Documentation
NetworkVariableCollectionsTests