-
Notifications
You must be signed in to change notification settings - Fork 464
fix: collections not detecting deltas #3004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
NoelStephensUnity
merged 13 commits into
develop-2.0.0
from
fix/managed-collections-not-detecting-deltas
Aug 13, 2024
Merged
fix: collections not detecting deltas #3004
NoelStephensUnity
merged 13 commits into
develop-2.0.0
from
fix/managed-collections-not-detecting-deltas
Aug 13, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using collections with NetworkVariable, it would only detect a completely new assignment of a collection but would not detect a change to an already assigned collection (add, remove, insert, clear) nor was there a convenient way to check if a collection or the values of its items/elements were dirty.
MTTB-305
fix: #2993
Changelog
NetworkVariable.CheckDirtyStatethat is to be used in tandem with collections in order to detect whether the collection or an item within the collection has changed.NetworkVariablewhere the collection would not detect changes to items or nested items.List,Dictionary, andHashSetcollections would not uniquely duplicate nested collections.NetworkListto exiting early with a logged error that is now a unified permissions message withinNetworkVariableBase.NetworkVariable.Valueto exiting early with a logged error that is now a unified permissions message withinNetworkVariableBase.Testing and Documentation
NetworkVariableCollectionsTests.