Skip to content

Conversation

@julienf-unity
Copy link
Contributor

Purpose of this PR

Fixed:

  • Target GameObject attach button does not allow attaching a valid VFX if the last selection was invalid. Case 1312178
  • Deleting flow edge between Init and Update throw an invalid opeation exception Case 1315593
  • Having more than five GPU Event output leads to "unexpected token 'if" at compilation Case 1323434
  • Deleted properties still show up in the inspector Case 1320952
  • Regression with some settings not always triggering a recompilation Case 1322844
  • Exception in VFXFilterWindow if search field is empty Case 1235269
  • Some doc updates

Testing status

Test green locally


Comments to reviewers

Notes for the reviewers you have assigned.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@gabrieldelacruz
Copy link
Contributor

The fix for Case 1323434 (Having more than five GPU Event output leads to "unexpected token 'if" at compilation) is generating some warnings. Earlier this week we discussed a different fix, replacing "i{0}" by "i_{0}" instead of "i". Maybe is a good time to do the change here?
I created a different PR for vfx/staging

@julienf-unity
Copy link
Contributor Author

The fix for Case 1323434 (Having more than five GPU Event output leads to "unexpected token 'if" at compilation) is generating some warnings. Earlier this week we discussed a different fix, replacing "i{0}" by "i_{0}" instead of "i". Maybe is a good time to do the change here?
I created a different PR for vfx/staging

Ok I copied the changed line and commit

@julienf-unity julienf-unity merged commit a981a66 into 10.x.x/release Apr 17, 2021
@julienf-unity julienf-unity deleted the 10.x.x/vfx/staging branch April 17, 2021 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants