[VFX] 10.x.x backports (#4208)

Fixed:

Target GameObject attach button does not allow attaching a valid VFX if the last selection was invalid. Case 1312178
Deleting flow edge between Init and Update throw an invalid opeation exception Case 1315593
Having more than five GPU Event output leads to "unexpected token 'if" at compilation Case 1323434
Deleted properties still show up in the inspector Case 1320952
Regression with some settings not always triggering a recompilation Case 1322844
Exception in VFXFilterWindow if search field is empty Case 1235269
Some doc updates

Author: julienf-unity

TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/Editor/Tests/VFXGUITests.cs

@@ -35,6 +35,8 @@ public void DestroyTestAssets()
 
             for (int i = 0; i < testAssetCount; ++i)
                 DestroyTestAsset("GUITest" + i);
+
+            VFXTestCommon.DeleteAllTemporaryGraph();
         }
 
         public static void RunGUITests()
@@ -402,6 +404,50 @@ public void CreateAllDataEdgesTest()
             EditTestAsset(6);
             CreateDataEdges(CreateAllOutputBlocks(), CreateAllParameters());
         }
+
+
+        public static readonly bool[] Create_Simple_Graph_Then_Remove_Edget_Between_Init_And_Update_TestCase = { true, false };
+        //Cover issue from 1315593 with system name
+        [UnityTest]
+        public IEnumerator Create_Simple_Graph_Then_Remove_Edget_Between_Init_And_Update([ValueSource(nameof(Create_Simple_Graph_Then_Remove_Edget_Between_Init_And_Update_TestCase))] bool autoCompile)
+        {
+            var graph = VFXTestCommon.MakeTemporaryGraph();
+            var path = AssetDatabase.GetAssetPath(graph);
+
+            var spawner = ScriptableObject.CreateInstance<VFXBasicSpawner>();
+
+            var init = ScriptableObject.CreateInstance<VFXBasicInitialize>();
+            var update = ScriptableObject.CreateInstance<VFXBasicUpdate>();
+            var output = ScriptableObject.CreateInstance<VFXPlanarPrimitiveOutput>();
+
+            graph.AddChild(spawner);
+            graph.AddChild(init);
+            graph.AddChild(update);
+            graph.AddChild(output);
+
+            init.LinkFrom(spawner);
+            update.LinkFrom(init);
+            output.LinkFrom(update);
+            AssetDatabase.ImportAsset(path);
+            yield return null;
+
+            //The issue is actually visible in VFXView
+            var window = EditorWindow.GetWindow<VFXViewWindow>();
+            window.Show();
+            var bckpAutoCompile = window.autoCompile;
+            window.autoCompile = autoCompile;
+            window.LoadAsset(graph.GetResource().asset, null);
+
+            //update.UnlinkFrom(init); //Doesn't reproduce the issue
+            var allFlowEdges = window.graphView.controller.allChildren.OfType<VFXFlowEdgeController>().ToArray();
+            var flowEdgeToDelete = allFlowEdges.Where(o => o.output.context.model.contextType == VFXContextType.Init && o.input.context.model.contextType == VFXContextType.Update).ToArray();
+            Assert.AreEqual(1u, flowEdgeToDelete.Length);
+            window.graphView.controller.Remove(flowEdgeToDelete);
+            window.graphView.controller.NotifyUpdate(); //<= This function will indirectly try to access system name before update (called by VFXView.Update
+            yield return null;
+
+            window.autoCompile = bckpAutoCompile;
+        }
     }
 }
 #endif

TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/VFXTests/GraphicsTests/Shadergraph/SampleScene/ShadergraphSampleScene/LightingData.asset

@@ -5,15 +5,20 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
 ## [10.5.0] - 2020-03-15
-
-Version Updated
-The version number for this package has increased due to a version update of a related graphics package.
+### Fixed
+- Target GameObject attach button does not allow attaching a valid VFX if the last selection was invalid. [Case 1312178](https://issuetracker.unity3d.com/product/unity/issues/guid/1312178/)
+- Deleting flow edge between Init and Update throw an invalid opeation exception [Case 1315593](https://issuetracker.unity3d.com/product/unity/issues/guid/1315593/)
+- Having more than five GPU Event output leads to "unexpected token 'if" at compilation [Case 1323434](https://issuetracker.unity3d.com/product/unity/issues/guid/1323434/)
+- Deleted properties still show up in the inspector [Case 1320952](https://issuetracker.unity3d.com/product/unity/issues/guid/1320952/)
+- Regression with some settings not always triggering a recompilation [Case 1322844](https://issuetracker.unity3d.com/product/unity/issues/guid/1322844/)
+- Exception in VFXFilterWindow if search field is empty [Case 1235269](https://issuetracker.unity3d.com/product/unity/issues/guid/1235269/)
 
 ## [10.4.0] - 2020-01-26
 ### Changed
 - Sphere and Cube outputs are now experimental
 - Property Binder : Handle Remove Component removing linked hidden scriptable objectfields
 - Property Binder : Prevent multiple VFXPropertyBinder within the same game object
+- Tidy up of platform abstraction code for random number generation, requires a dependency on com.unity.render-pipelines.core for those abstractions.
 
 ### Fixed
 - VFXEventBinderBase throwing a null reference exception in runtime
@@ -34,9 +39,6 @@ The version number for this package has increased due to a version update of a r
 - Deleting a context node and a block while both are selected throws a null ref exception. [Case 315578](https://issuetracker.unity3d.com/product/unity/issues/guid/1315578/)
 - Fixed shader compilation errors with textures in shader graph [Case 1309219](https://issuetracker.unity3d.com/product/unity/issues/guid/1309219/)
 - Fixed issue with VFX using incorrect buffer type for strip data
-
-### Changed
-- Tidy up of platform abstraction code for random number generation, requires a dependency on com.unity.render-pipelines.core for those abstractions.
 
 ## [10.3.1] - 2020-01-26
 

TestProjects/VisualEffectGraph_HDRP/Assets/AllTests/VFXTests/GraphicsTests/Shadergraph/SampleScene/ShadergraphSampleScene/ReflectionProbe-0.exr

@@ -6,7 +6,7 @@ The **Set Attribute from Map** Block is a generic Block that calculates values b
 
 To achieve different results, this Block can use various sampling modes. The sampling modes are:
 
-- **Index**, **IndexRelative**, and **Sequential** sample modes use particle indices to sample the pixels of the texture. These modes can sample [Point Caches](PointCaches.md) or [Attribute Maps](PropertyBinders.md) in various ways.
+- **Index**, **IndexRelative**, and **Sequential** sample modes use particle indices to sample the pixels of the texture. These modes can sample [Point Caches](point-cache-in-vfx-graph.md) or [Attribute Maps](PropertyBinders.md) in various ways.
 - **Sample2DLOD** and **Sample3DLOD** sample modes use 2D and 3D coordinates and a LOD factor to sample the texture. You can use these modes for projection of various values such as color or depth.
 - **Random** and **RandomUniformPerParticle** sample modes allow you to fetch random values from a pool of values stored in a texture, such as Point Caches or Attribute Maps.