-
Notifications
You must be signed in to change notification settings - Fork 861
[Yamato] Refactor ABV #2843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Yamato] Refactor ABV #2843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kivistikliis
reviewed
Dec 8, 2020
kivistikliis
reviewed
Dec 8, 2020
kivistikliis
approved these changes
Dec 8, 2020
theopnv
suggested changes
Dec 8, 2020
Contributor
theopnv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really impressive work, this will help so much, thanks! 👏
Last question, should this file be removed now that we have an updated contributing guide?
theopnv
approved these changes
Dec 9, 2020
theopnv
approved these changes
Dec 10, 2020
sophiaaar
added a commit
that referenced
this pull request
Jan 26, 2021
* backport #2843 * backport #2883 * backport #3002 * shadergraph osx editor images * move shadergraph linux vulkan images * pdate vfx images * update shadergraph ios images * remove linux vulkan standalone from urp ci * backport #3130 * backport #3175 * backport f61eaa4 * edit pr job and nightly * part 2 * change timeout for standalone cache * update hdrp images * fix expression trigger branch * backport #3254 * remove trigger from custom revision jobs
pastasfuture
pushed a commit
that referenced
this pull request
Mar 15, 2021
* backport #2843 * backport #2883 * backport #3002 * shadergraph osx editor images * move shadergraph linux vulkan images * pdate vfx images * update shadergraph ios images * remove linux vulkan standalone from urp ci * backport #3130 * backport #3175 * backport f61eaa4 * edit pr job and nightly * part 2 * change timeout for standalone cache * update hdrp images * fix expression trigger branch * backport #3254 * remove trigger from custom revision jobs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
Testing status
Started (then cancelled) jobs to check the dependencies are correct and that no jobs are duplicated
Comments to reviewers
When viewing the files changed, untick "png" and "meta" in the file filter so you can skip the reference images