Skip to content

Conversation

@sophiaaar
Copy link
Contributor

@sophiaaar sophiaaar commented Dec 4, 2020

Purpose of this PR


Testing status

Started (then cancelled) jobs to check the dependencies are correct and that no jobs are duplicated


Comments to reviewers

When viewing the files changed, untick "png" and "meta" in the file filter so you can skip the reference images

Copy link
Contributor

@theopnv theopnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really impressive work, this will help so much, thanks! 👏

Last question, should this file be removed now that we have an updated contributing guide?

@sophiaaar sophiaaar requested a review from theopnv December 8, 2020 17:16
@sophiaaar sophiaaar merged commit aa68ea0 into master Dec 10, 2020
@sophiaaar sophiaaar deleted the yamato/refactor-abv branch December 10, 2020 11:46
sophiaaar added a commit that referenced this pull request Jan 19, 2021
sophiaaar added a commit that referenced this pull request Jan 26, 2021
* backport #2843

* backport #2883

* backport #3002

* shadergraph osx editor images

* move shadergraph linux vulkan images

* pdate vfx images

* update shadergraph ios images

* remove linux vulkan standalone from urp ci

* backport #3130

* backport #3175

* backport f61eaa4

* edit pr job and nightly

* part 2

* change timeout for standalone cache

* update hdrp images

* fix expression trigger branch

* backport #3254

* remove trigger from custom revision jobs
pastasfuture pushed a commit that referenced this pull request Mar 15, 2021
* backport #2843

* backport #2883

* backport #3002

* shadergraph osx editor images

* move shadergraph linux vulkan images

* pdate vfx images

* update shadergraph ios images

* remove linux vulkan standalone from urp ci

* backport #3130

* backport #3175

* backport f61eaa4

* edit pr job and nightly

* part 2

* change timeout for standalone cache

* update hdrp images

* fix expression trigger branch

* backport #3254

* remove trigger from custom revision jobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants