Supporting SSGI in the render graph mode. #1697
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
|
|
||
| static void Denoise(CommandBuffer cmd, SSGIDenoiserParameters parameters, SSGIDenoiserResources resources) | ||
| { | ||
| if (resources.historyDepthBuffer == null) |
Contributor
There was a problem hiding this comment.
Can we do this test outside the funciton? If it fails it means we still need to run a render graph pass through the system and we'll also get an empty profiling marker.
JulienIgnace-Unity
suggested changes
Aug 28, 2020
Contributor
JulienIgnace-Unity
left a comment
JulienIgnace-Unity
left a comment
There was a problem hiding this comment.
- Move StartXRSinglePass before SSGI as in regular code path
- Remove obsolete commented code
Merged
JulienIgnace-Unity
approved these changes
Sep 2, 2020
Contributor
|
Testing manually on Amelienborg palace. Checked Raytracing enabled/disabled with render graph mode on/off. Works as expected
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that we have no tests for ssgi due the current limitation of the test framework. I tested manually, but I ain't compltely sure. Plus, there is some improvements i'd like to merge that change compltely the output of the effect.
Testing status
None