Skip to content

Conversation

@FrancescoC-unity
Copy link
Contributor

Added a macro to help on the creation of the offset that the lane swizzle intrinsic requires.

@github-actions
Copy link

It appears that you made a non-draft PR!
Please convert your PR to draft (button on the right side of the page)
and cancel any jobs that started on Yamato.
See the PR template for more information.
Thank you!

@EvgeniiG
Copy link
Contributor

Could you test this on the AABB PR, please?
Also, could you perhaps also expose LaneSwizzle(v, andMask, orMask, xorMask) as a macro? Note: only for XBox.
Thanks!

@FrancescoC-unity
Copy link
Contributor Author

Could you test this on the AABB PR, please?
Also, could you perhaps also expose LaneSwizzle(v, andMask, orMask, xorMask) as a macro? Note: only for XBox.
Thanks!

Sure, if you make the loops into macros I'll give it a shot tomorrow morning.

@EvgeniiG
Copy link
Contributor

Could you test this on the AABB PR, please?
Also, could you perhaps also expose LaneSwizzle(v, andMask, orMask, xorMask) as a macro? Note: only for XBox.
Thanks!

Sure, if you make the loops into macros I'll give it a shot tomorrow morning.

If the existing loop with constant parameters doesn't work I may as well just write a specific version for Xbox...

@FrancescoC-unity
Copy link
Contributor Author

Could you test this on the AABB PR, please?
Also, could you perhaps also expose LaneSwizzle(v, andMask, orMask, xorMask) as a macro? Note: only for XBox.
Thanks!

Sure, if you make the loops into macros I'll give it a shot tomorrow morning.

If the existing loop with constant parameters doesn't work I may as well just write a specific version for Xbox...

As is now even with the macro it doesn't work since it is not using literals (i.e. the xorMask is using the index of the loop, need explicit unrolling)

@sebastienlagarde sebastienlagarde merged commit fb92380 into HDRP/staging Sep 2, 2020
@sebastienlagarde sebastienlagarde deleted the HDRP/macro-helper-for-lane-swizzle-mask branch September 2, 2020 16:38
@sebastienlagarde sebastienlagarde mentioned this pull request Sep 3, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants