Skip to content

Fix for area light emissive mesh not appearing in playmode when Reload Scene is disabled #1504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 5, 2020
Merged

Fix for area light emissive mesh not appearing in playmode when Reload Scene is disabled #1504

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e1c5c0b
Create emissive mesh if not created but is requested.
FrancescoC-unity Aug 4, 2020
4421f62
Changelog
FrancescoC-unity Aug 4, 2020
b5550b3
Remove unnecessary create function call
FrancescoC-unity Aug 4, 2020
d60bf2f
Merge branch 'HDRP/staging' into HDRP/fix-emissive-mesh-not-displayin…
sebastienlagarde Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.render-pipelines.high-definition/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -757,6 +757,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
- Fixed incorrect processing of Ambient occlusion probe (9% error was introduced)
- Fixed GPU hang on D3D12 on xbox.
- Fix several issues with physically-based DoF (TAA ghosting of the CoC buffer, smooth layer transitions, etc)
- Fixed issue with emissive mesh for area light not appearing in playmode if Reload Scene option is disabled in Enter Playmode Settings.

### Changed
- Improve MIP selection for decals on Transparents
Expand Down
8 changes: 8 additions & 0 deletions com.unity.render-pipelines.high-definition/Runtime/Lighting/Light/HDAdditionalLightData.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2311,6 +2311,14 @@ void LateUpdate()
#endif

#if UNITY_EDITOR

// If we requested an emissive mesh but for some reason (e.g. Reload scene unchecked in the Enter Playmode options) Awake has not been called,
// we need to create it manually.
if (m_DisplayAreaLightEmissiveMesh && (m_ChildEmissiveMeshViewer == null || m_ChildEmissiveMeshViewer.Equals(null)))
{
UpdateAreaLightEmissiveMesh();
}

//if not parented anymore, refresh it
if (m_ChildEmissiveMeshViewer != null && !m_ChildEmissiveMeshViewer.Equals(null))
{
Expand Down