Fix for area light emissive mesh not appearing in playmode when Reload Scene is disabled #1504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasKiniulis
approved these changes
Aug 5, 2020
sebastienlagarde
approved these changes
Aug 5, 2020
…g-when-reload-scene-is-off
sebastienlagarde
deleted the
HDRP/fix-emissive-mesh-not-displaying-when-reload-scene-is-off
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for https://fogbugz.unity3d.com/f/cases/1265021
Issue was that mesh is generally created in the Awake() function, which however is never called if the 'Reload Scene' option in the Enter Playmode Settings.
This change essentially make sure that by the time LateUpdate is called, the mesh is created if it has not been yet.
What have I tested: I tested the repro case, I also tried to change properties before (in edit mode) and after (in playmode) and see they applied. I tried with the Reload Scene on or off.