[Hdrp][Compositor] Fix flickering with camera stacking #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It appears that you made a non-draft PR! |
pmavridis
changed the title
TomasKiniulis
approved these changes
Aug 6, 2020
Contributor
TomasKiniulis
left a comment
TomasKiniulis
left a comment
There was a problem hiding this comment.
From the description, looks like this has been tested extensively already and tests are green
sebastienlagarde
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
https://fogbugz.unity3d.com/f/cases/1264552/
https://fogbugz.unity3d.com/f/cases/1266223/
Camera stacking was broken in the graphics compositor (we were getting flickering) because the draw-order of the layer cameras was overwritten when updating other runtime properties.
This PR also fixes some errors that we were getting because the internal layer cameras, which are created as clones of the user cameras, were also cloning children and other components.
Testing status