Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MetaMask Mobile compatibility fix #71

Merged
merged 1 commit into from
Jan 31, 2020

Conversation

bpierre
Copy link
Contributor

@bpierre bpierre commented Jan 31, 2020

In the current version (0.2.13) of MetaMask Mobile, ethereum.chainId starts with “Ox” rather than “0x”.

The fix should be in the next version, but we might want to keep this for a bit until MetaMask Mobile users are up to date.

Reference: MetaMask/metamask-mobile#1275

@NoahZinsmeister
Copy link
Contributor

NoahZinsmeister commented Jan 31, 2020

wow, that's crazy 😐. thanks for this fix @bpierre , will merge after the CI finishes and will release a new version ASAP.

@NoahZinsmeister NoahZinsmeister merged commit 008848e into Uniswap:v6 Jan 31, 2020
@bpierre bpierre deleted the metamask-mobile-fix branch January 31, 2020 16:25
@NoahZinsmeister
Copy link
Contributor

published as @web3-react/[email protected]

@bpierre
Copy link
Contributor Author

bpierre commented Jan 31, 2020

Awesome, thanks @NoahZinsmeister! 🙌

@NoahZinsmeister
Copy link
Contributor

thank you!

bpierre added a commit to aragon/anj.aragon.org that referenced this pull request Jan 31, 2020
bpierre added a commit to aragon/anj.aragon.org that referenced this pull request Jan 31, 2020
bpierre added a commit to aragon/use-wallet that referenced this pull request Feb 24, 2020
Fix a connection issue with MetaMask mobile [1].

[1] Uniswap/web3-react#71
soft-proactive pushed a commit to soft-proactive/use-wallet that referenced this pull request May 24, 2021
Fix a connection issue with MetaMask mobile [1].

[1] Uniswap/web3-react#71
davidsoft318 added a commit to davidsoft318/use-wallet that referenced this pull request May 28, 2021
Fix a connection issue with MetaMask mobile [1].

[1] Uniswap/web3-react#71
venuswhispers added a commit to venuswhispers/My_Usewallet that referenced this pull request Feb 19, 2024
Fix a connection issue with MetaMask mobile [1].

[1] Uniswap/web3-react#71
devstar1014 added a commit to devstar1014/My_Usewallet that referenced this pull request Aug 8, 2024
Fix a connection issue with MetaMask mobile [1].

[1] Uniswap/web3-react#71
montedev0516 added a commit to montedev0516/-my_USE_wallet that referenced this pull request Nov 19, 2024
Fix a connection issue with MetaMask mobile [1].

[1] Uniswap/web3-react#71
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants