Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: inpage bridge chainid #1275

Merged
merged 1 commit into from
Jan 13, 2020
Merged

bugfix: inpage bridge chainid #1275

merged 1 commit into from
Jan 13, 2020

Conversation

estebanmino
Copy link
Contributor

Description

Inpage was returning Ox instead of 0x
fixes #1274

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #???

brunobar79
brunobar79 approved these changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@estebanmino estebanmino mentioned this pull request Jan 13, 2020
Closed
@estebanmino estebanmino merged commit 99c844e into develop Jan 13, 2020
@estebanmino estebanmino deleted the bugfix/inpage-bridge-chainid branch January 13, 2020 19:24
@bpierre bpierre mentioned this pull request Jan 31, 2020
Merged
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix: inpage bridge chainid (#1275)
95fbd06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brunobar79 brunobar79 brunobar79 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

provider.chainId is invalid hex number
2 participants
@estebanmino @brunobar79