feat: log swap failures to amplitude #6789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vm
reviewed
Jun 16, 2023
| @@ -441,6 +441,11 @@ export function Swap({ | |||
| }) | |||
| }) | |||
| .catch((error) => { | |||
| if (!didUserReject(error)) { | |||
| sendAnalyticsEvent(SwapEventName.SWAP_ERROR, { | |||
| confirmedTrade: tradeToConfirm, | |||
There was a problem hiding this comment.
are you sure that sending a full object will be okay here? if yes then all good
There was a problem hiding this comment.
there should be a way to test sending into the amplitude dev environment if you want to try that. i worry you won't be able to filter properly this way
There was a problem hiding this comment.
1 flaky tests on run #12029 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Permit2 > approval process (with intermediate screens) > swaps after completing full permit2 approval process |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
natew
approved these changes
Jun 16, 2023
zzmp
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
logs swap failures to amplitude for trend tracking.
Linear ticket: https://linear.app/uniswap/issue/WEB-2307/log-swap-failures-to-amplitude
Screen capture
Test plan
Reproducing the error
tradeToConfirmis properly included in theQA (ie manual testing)