Skip to content

Commit

Permalink
chore: migrate from JIRA to Linear (#6747)
Browse files Browse the repository at this point in the history
* chore: migrate from JIRA to Linear

* INFRA -> WEB
  • Loading branch information
vm authored Jun 16, 2023
1 parent 2d61c72 commit f3889e3
Show file tree
Hide file tree
Showing 21 changed files with 22 additions and 22 deletions.
2 changes: 1 addition & 1 deletion src/components/AccountDrawer/MiniPortfolio/ExpandoRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const Wrapper = styled(Column)<{ numItems: number; isExpanded: boolean }>`
overflow: hidden;
`

// TODO(WEB-3288): Replace this component to use `components/Expand` under the hood
// TODO(WEB-1982): Replace this component to use `components/Expand` under the hood
type ExpandoRowProps = PropsWithChildren<{ title?: string; numItems: number; isExpanded: boolean; toggle: () => void }>
export function ExpandoRow({ title = t`Hidden`, numItems, isExpanded, toggle, children }: ExpandoRowProps) {
if (numItems === 0) return null
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export const DEFAULT_GAS_LIMIT = 1_000_000
const Erc20 = new Interface(ERC20_ABI) as Erc20Interface
const Erc20Bytes32 = new Interface(ERC20_ABI) as Erc20Bytes32Interface // Used for tokens that return bytes32 for name/symbol rather than string

// TODO(WEB-3060): cartcrom - adapt support for multi-function multi-interface multicalls into redux-multicall to remove than this custom cache/chunking logic
// TODO(WEB-1760): cartcrom - adapt support for multi-function multi-interface multicalls into redux-multicall to remove than this custom cache/chunking logic
// Infura rejects calls with gas costs > 10x the current block gas limit; in such case we split the call into 2 chunks
async function fetchChunk(multicall: UniswapInterfaceMulticall, chunk: Call[]): Promise<CallResult[]> {
try {
Expand Down
2 changes: 1 addition & 1 deletion src/components/Row/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Box } from 'rebass/styled-components'
import styled from 'styled-components/macro'
import { Gap } from 'theme'

// TODO(WEB-3289):
// TODO(WEB-1983):
// Setting `width: 100%` by default prevents composability in complex flex layouts.
// Same applies to `RowFixed` and its negative margins. This component needs to be
// further investigated and improved to make UI work easier.
Expand Down
4 changes: 2 additions & 2 deletions src/components/Tooltip/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ type TooltipProps = Omit<PopoverProps, 'content'> & {
timeout?: number
}

// TODO(WEB-3305)
// TODO(WEB-2024)
// Migrate to MouseoverTooltip and move this component inline to MouseoverTooltip
export default function Tooltip({ text, open, close, disabled, size = TooltipSize.Small, ...rest }: TooltipProps) {
return (
Expand All @@ -64,7 +64,7 @@ export default function Tooltip({ text, open, close, disabled, size = TooltipSiz
)
}

// TODO(WEB-3305)
// TODO(WEB-2024)
// Do not pass through PopoverProps. Prefer higher-level interface to control MouseoverTooltip.
type MouseoverTooltipProps = Omit<PopoverProps, 'content' | 'show'> &
PropsWithChildren<{
Expand Down
2 changes: 1 addition & 1 deletion src/components/swap/GasEstimateTooltip.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function GasEstimateTooltip({
<MouseoverTooltip
disabled={disabled}
size={TooltipSize.Large}
// TODO(WEB-3304)
// TODO(WEB-2246)
// Most of Swap-related components accept either `syncing`, `loading` or both props at the same time.
// We are often using them interchangeably, or pass both values as one of them (`syncing={loading || syncing}`).
// This is confusing and can lead to unpredicted UI behavior. We should refactor and unify this.
Expand Down
2 changes: 1 addition & 1 deletion src/components/swap/SwapRoute.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default function SwapRoute({ trade, syncing }: { trade: InterfaceTrade; s
const routes = getRoutingDiagramEntries(trade)

const gasPrice =
// TODO(WEB-3303)
// TODO(WEB-2022)
// Can `trade.gasUseEstimateUSD` be defined when `chainId` is not in `SUPPORTED_GAS_ESTIMATE_CHAIN_IDS`?
trade.gasUseEstimateUSD && chainId && SUPPORTED_GAS_ESTIMATE_CHAIN_IDS.includes(chainId)
? trade.gasUseEstimateUSD === '0.00'
Expand Down
2 changes: 1 addition & 1 deletion src/connection/activate.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ function useTryActivation() {
return
}

// TODO(WEB-3162): re-add special treatment for already-pending injected errors & move debug to after didUserReject() check
// TODO(WEB-1859): re-add special treatment for already-pending injected errors & move debug to after didUserReject() check
console.debug(`Connection failed: ${connection.getName()}`)
console.error(error)

Expand Down
2 changes: 1 addition & 1 deletion src/connection/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ export enum ErrorCode {
CB_REJECTED_REQUEST = 'Error: User denied account authorization',
}

// TODO(WEB-3279): merge this function with existing didUserReject for Swap errors
// TODO(WEB-1973): merge this function with existing didUserReject for Swap errors
export function didUserReject(connection: Connection, error: any): boolean {
return (
error?.code === ErrorCode.USER_REJECTED_REQUEST ||
Expand Down
2 changes: 1 addition & 1 deletion src/constants/lists.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ export const UNI_EXTENDED_LIST = 'https://gateway.ipfs.io/ipns/extendedtokens.un
const UNI_UNSUPPORTED_LIST = 'https://gateway.ipfs.io/ipns/unsupportedtokens.uniswap.org'
const AAVE_LIST = 'tokenlist.aave.eth'
const BA_LIST = 'https://raw.githubusercontent.com/The-Blockchain-Association/sec-notice-list/master/ba-sec-list.json'
// TODO(INFRA-179): Re-enable CMC list once we have a better solution for handling large lists.
// TODO(WEB-2282): Re-enable CMC list once we have a better solution for handling large lists.
// const CMC_ALL_LIST = 'https://s3.coinmarketcap.com/generated/dex/tokens/eth-tokens-all.json'
const COINGECKO_LIST = 'https://tokens.coingecko.com/uniswap/all.json'
const COINGECKO_BNB_LIST = 'https://tokens.coingecko.com/binance-smart-chain/all.json'
Expand Down
2 changes: 1 addition & 1 deletion src/constants/misc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import JSBI from 'jsbi'

export const ZERO_ADDRESS = '0x0000000000000000000000000000000000000000'

// TODO(WEB-3290): Convert the deadline to minutes and remove unecessary conversions from
// TODO(WEB-1984): Convert the deadline to minutes and remove unecessary conversions from
// seconds to minutes in the codebase.
// 30 minutes, denominated in seconds
export const DEFAULT_DEADLINE_FROM_NOW = 60 * 30
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/Tokens.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ function useTokensFromMap(tokenMap: TokenAddressMap, chainId: Maybe<SupportedCha
}, [chainId, tokenMap])
}

// TODO(INFRA-164): after disallowing unchecked index access, refactor ChainTokenMap to not use ?'s
// TODO(WEB-2347): after disallowing unchecked index access, refactor ChainTokenMap to not use ?'s
export type ChainTokenMap = { [chainId in number]?: { [address in string]?: Token } }
/** Returns tokens from all token lists on all chains, combined with user added tokens */
export function useAllTokensMultichain(): ChainTokenMap {
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/useV3PositionFees.ts
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ export function useV3PositionFees(
} catch {
// If the static call fails, the default state will remain for `amounts`.
// This case is handled by returning unclaimed fees as empty.
// TODO(INFRA-178): Look into why we have failures with call data being 0x.
// TODO(WEB-2283): Look into why we have failures with call data being 0x.
}
}
})()
Expand Down
2 changes: 1 addition & 1 deletion src/lib/hooks/useCurrency.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ export function useTokenFromActiveNetwork(tokenAddress: string | undefined): Tok
const tokenContract = useTokenContract(formattedAddress ? formattedAddress : undefined, false)
const tokenContractBytes32 = useBytes32TokenContract(formattedAddress ? formattedAddress : undefined, false)

// TODO (WEB-3009): reduce this to one RPC call instead of 5
// TODO (WEB-1709): reduce this to one RPC call instead of 5
// TODO: Fix redux-multicall so that these values do not reload.
const tokenName = useSingleCallResult(tokenContract, 'name', undefined, NEVER_RELOAD)
const tokenNameBytes32 = useSingleCallResult(tokenContractBytes32, 'name', undefined, NEVER_RELOAD)
Expand Down
2 changes: 1 addition & 1 deletion src/lib/hooks/useTokenList/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { TokenInfo, TokenList } from '@uniswap/token-lists'
import { WrappedTokenInfo } from 'state/lists/wrappedTokenInfo'

type TokenMap = Readonly<{ [tokenAddress: string]: { token: WrappedTokenInfo; list?: TokenList } }>
// TODO(INFRA-164): replace usage of the misnomered TokenAddressMap w/ ChainTokenMap from src/hooks/Tokens.ts
// TODO(WEB-2347): replace usage of the misnomered TokenAddressMap w/ ChainTokenMap from src/hooks/Tokens.ts
export type TokenAddressMap = Readonly<{ [chainId: number]: TokenMap }>

type Mutable<T> = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@ it('data page trait component does not load with asset with no traits', () => {
expect(asFragment()).toMatchSnapshot()
})

// TODO(NFT-1189): add test for trait component with asset with traits when rarity is not randomly generated
// TODO(NFT-1114): add test for trait component with asset with traits when rarity is not randomly generated
// while rarities are randomly generated, snapshots will never match
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import { TableContentComponent } from './TableContentComponent'
import { ContentRow, HeaderRow } from './TableRowComponent'

export const OffersTableContent = ({ asset }: { asset: GenieAsset }) => {
// TODO(NFT-1189) Replace with real offer data when BE supports
// TODO(NFT-1114) Replace with real offer data when BE supports
const mockOffers = new Array(11).fill(TEST_OFFER)
const isMobile = useIsMobile()
const theme = useTheme()
Expand Down
2 changes: 1 addition & 1 deletion src/nft/components/details/detailsV2/TraitRow.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ const TraitRowValue = styled(ThemedText.BodySmall)<{ $flex?: number; $justifyCon
`

export const TraitRow = ({ trait, collectionAddress }: { trait: Trait; collectionAddress: string }) => {
// TODO(NFT-1189): Replace with actual rarity, count, and floor price when BE supports
// TODO(NFT-1114): Replace with actual rarity, count, and floor price when BE supports
// rarity eventually should be number of items with this trait / total number of items, smaller rarity means more rare
const randomRarity = Math.random()
const rarityLevel = getRarityLevel(randomRarity)
Expand Down
2 changes: 1 addition & 1 deletion src/state/routing/useRoutingAPITrade.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ export function useRoutingAPITrade<TTradeType extends TradeType>(
} else if (tradeResult?.state === QuoteState.NOT_FOUND && isCurrent) {
return TRADE_NOT_FOUND
} else if (!tradeResult?.trade) {
// TODO(WEB-3307): use `isLoading` returned by rtk-query hook instead of checking for `trade` status
// TODO(WEB-1985): use `isLoading` returned by rtk-query hook instead of checking for `trade` status
return TRADE_LOADING
} else {
return {
Expand Down
2 changes: 1 addition & 1 deletion src/state/user/hooks.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export function useUserSlippageTolerance(): [
return state.user.userSlippageTolerance
})

// TODO(WEB-3291): Keep `userSlippageTolerance` as Percent in Redux store and remove this conversion
// TODO(WEB-1985): Keep `userSlippageTolerance` as Percent in Redux store and remove this conversion
const userSlippageTolerance = useMemo(
() =>
userSlippageToleranceRaw === SlippageTolerance.Auto
Expand Down
2 changes: 1 addition & 1 deletion src/tracing/errors.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function shouldRejectError(error: EventHint['originalException']) {

// Content security policy 'unsafe-eval' errors can be filtered out because there are expected failures.
// For example, if a user runs an eval statement in console this error would still get thrown.
// TODO(INFRA-176): We should extend this to filter out any type of CSP error.
// TODO(WEB-2348): We should extend this to filter out any type of CSP error.
if (error.message.match(/'unsafe-eval'.*content security policy/i)) {
return true
}
Expand Down
2 changes: 1 addition & 1 deletion src/utils/prices.ts
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ export function warningSeverity(priceImpact: Percent | undefined): WarningSeveri
// Price Impact is always an absolute value (conceptually always negative, but represented in code with a positive value)
// The USD value change can be positive or negative, and it follows the same standard as Price Impact (positive value is the typical case of a loss due to slippage).
// We don't want to return a warning level for a favorable/profitable change, so when the USD value change is negative we return 0.
// TODO (WEB-3133): Disambiguate Price Impact and USD value change, and flip the sign of USD Value change.
// TODO (WEB-1833): Disambiguate Price Impact and USD value change, and flip the sign of USD Value change.
if (priceImpact.lessThan(0)) return 0
let impact: WarningSeverity = IMPACT_TIERS.length as WarningSeverity
for (const impactLevel of IMPACT_TIERS) {
Expand Down

1 comment on commit f3889e3

@vercel
Copy link

@vercel vercel bot commented on f3889e3 Jun 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

interface – ./

interface-git-main-uniswap.vercel.app
interface-uniswap.vercel.app

Please sign in to comment.