Skip to content

clang format settings explicitly listed, enabled macOS build#92

Merged
ilijapuaca merged 5 commits intomasterfrom
bugfix/ci
Apr 13, 2020
Merged

clang format settings explicitly listed, enabled macOS build#92
ilijapuaca merged 5 commits intomasterfrom
bugfix/ci

Conversation

@ilijapuaca
Copy link
Contributor

Linux build disabled until we figure out the dependency issues

@ilijapuaca
Copy link
Contributor Author

There's something weird going on with Linux build of clang-format. It is complaining about fields/values that are clearly defined per docs for v9, which can be found here: https://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormatStyleOptions.html

It runs fine on Mac with this version installed:
clang-format version 9.0.0 (tags/google/stable/2019-05-14)

Can package clang-format-9 really be that different compared to what's in the docs?

@@ -1,3 +1,156 @@
BasedOnStyle: Google
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave the old commented out and explain why we copy all these in.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this file copied from clang-format? Or generated? We should indicate where the file content came from.

Copy link
Contributor Author

@ilijapuaca ilijapuaca Apr 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generated using a command from the link I put at the top of the file, will elaborate more

@isaacbrodsky
Copy link
Contributor

There's something weird going on with Linux build of clang-format. It is complaining about fields/values that are clearly defined per docs for v9, which can be found here: https://releases.llvm.org/9.0.0/tools/clang/docs/ClangFormatStyleOptions.html

It runs fine on Mac with this version installed:
clang-format version 9.0.0 (tags/google/stable/2019-05-14)

Can package clang-format-9 really be that different compared to what's in the docs?

I got errors like this but it turned out it was using the wrong version of clang-format (I have both clang-format-6.0 and clang-format-9 installed). When I hard coded clang-format-9 it worked, I wonder if it's possible an older version of clang-format is being detected in CI, too?

This was referenced Apr 13, 2020
@ilijapuaca ilijapuaca changed the base branch from refactor/animometer to master April 13, 2020 05:01
@ilijapuaca ilijapuaca merged commit e2eb9ce into master Apr 13, 2020
@ilijapuaca ilijapuaca deleted the bugfix/ci branch April 13, 2020 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants