Skip to content

Luma API update, animometer example revisited#91

Merged
ilijapuaca merged 1 commit intomasterfrom
refactor/animometer
Apr 13, 2020
Merged

Luma API update, animometer example revisited#91
ilijapuaca merged 1 commit intomasterfrom
refactor/animometer

Conversation

@ilijapuaca
Copy link
Contributor

  • Revisited some of the API in Model/AnimationLoop
  • animometer example now uses the updated API instead of making calls to dawn API directly
  • Minor dependency cleanup

Few things worth noting:

  • There seems to be a memory leak in the run loop (it's there even in example provided by dawn, without any modifications)
  • Most of the WebGPU objects are being passed around by value across the API. This initially seemed weird to me so I started trying to turn them into pointers, which makes the function calls somewhat sloppy. Any particular reason they are being passed by value, are they that lightweight? I assumed that making copies of these was causing the memory leak, based on this text from WebGPU spec:

WebGPU sees physical GPU hardware as GPUAdapters. It provides a connection to an adapter via GPUDevice, which manages resources...

  • Did we give threading some thought when it comes to rendering?

@ilijapuaca
Copy link
Contributor Author

Landing this together with #92, will address any comments as they come

@ilijapuaca ilijapuaca merged commit 334ec9d into master Apr 13, 2020
@ilijapuaca ilijapuaca deleted the refactor/animometer branch April 17, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant