Fix incompatibility with GHC 9.2 and 9.4#11
Merged
jbransen merged 4 commits intoUU-ComputerScience:masterfrom Mar 26, 2023
Merged
Fix incompatibility with GHC 9.2 and 9.4#11jbransen merged 4 commits intoUU-ComputerScience:masterfrom
jbransen merged 4 commits intoUU-ComputerScience:masterfrom
Conversation
This field has been added in Cabal 3.8.1.0, which comes with GHC 9.4.
in GHC 9.4, the ST monad no longer is an instance of MonadFail. There is one place in the code where this goes wrong, namely in KennedyWarren.hs. The applied fix is according to this guide: https://github.com/haskell/core-libraries-committee/blob/main/guides/no-monadfail-st-inst.md
Member
|
Nice, thank you very much! |
Member
|
This has been published to Hackage now https://hackage.haskell.org/package/uuagc-0.9.54 |
Contributor
Author
|
Awesome, thanks! |
12 tasks
FPtje
added a commit
to FPtje/nixpkgs
that referenced
this pull request
Jun 8, 2023
The package is compatible with ghc 9.2 and 9.4 since the following PR was merged: UU-ComputerScience/uuagc#11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a Haskell Meetup somewhere last year, @jbransen and I discussed this wonderful gem. I see that it doesn't have many recent commits, so I'd love to help here and there to keep it up-to-date. One reason for this is that a hobby project of mine heavily relies on this library.
This PR brings UUAGC up to date with GHC 9.2 and GHC 9.4. The individual commits describe the different changes made. Tested with GHC 9.0, 9.2 and 9.4. Also tested with glualint on GHC 9.2.
I would have liked to try and fix it up for GHC 9.6 as well, but there are just way too many dependencies that fail to build. I guess we'll have to wait for that to settle down first :).
If desired, I can fix up and make a PR for a quick Nix flake that I wrote to run these tests.