haskellPackages.uuagc-cabal: Mark as no longer broken#236591
Merged
cdepillabout merged 2 commits intoNixOS:haskell-updatesfrom Jun 8, 2023
Merged
haskellPackages.uuagc-cabal: Mark as no longer broken#236591cdepillabout merged 2 commits intoNixOS:haskell-updatesfrom
cdepillabout merged 2 commits intoNixOS:haskell-updatesfrom
Conversation
FPtje
requested review from
cdepillabout,
maralorn and
sternenseemann
as code owners
github-actions
bot
added
the
6.topic: haskell
Contributor
Author
|
I see my editor trimmed trailing whitespace. Will fix 👍 |
FPtje
force-pushed
the
mark-uuagc-cabal-as-nonbroken
branch
from
d0a222c to
56f63d3
Compare
The package is compatible with ghc 9.2 and 9.4 since the following PR was merged: UU-ComputerScience/uuagc#11
FPtje
force-pushed
the
mark-uuagc-cabal-as-nonbroken
branch
from
56f63d3 to
8dd6e8f
Compare
cdepillabout
reviewed
Jun 8, 2023
| @@ -307562,7 +307562,6 @@ self: { | |||
| description = "Cabal plugin for UUAGC"; | |||
| license = lib.licenses.bsd3; | |||
| hydraPlatforms = lib.platforms.none; | |||
Member
There was a problem hiding this comment.
If you leave hydraPlatforms = lib.platforms.none, then this package doesn't actually get built on Hydra.
Suggested change
| hydraPlatforms = lib.platforms.none; |
edit: Hmm, I can't seem to commit this myself...
@FPtje could you add this to your PR?
Contributor
Author
There was a problem hiding this comment.
Ah, I had committed through the "Commit suggestion" button, but that sadly throws a consistent error. I've now committed and pushed it manually as 512c48d
Member
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Simple one-line change. Follows this discussion: #233112 (comment)
uuagc-cabalhas had an update to become compatible with ghc 9.2 and 9.4. PR here: UU-ComputerScience/uuagc#11Trying locally I found that
uuagc-cabalbuilds fine: #233112 (comment)As per instructions, I created this PR to mark as no longer broken.
Notes
uuagcalready did not have abrokenflag, so it did not need to be removeduuagc-.... Some of those are also marked as broken, but they didn't have the fix mentioned above.Things done
sandbox = trueset innix.conf? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)CC @cdepillabout