fix: 핀 등록 QA 이슈 수정 - #336
Conversation
|
Warning Review limit reached
Next review available in: 14 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (13)
📝 WalkthroughWalkthrough지도 핀 흐림 상태를 추가했다. 핀 등록 상태에 검색어와 확인 출처를 저장한다. 홈과 곡 상세 화면에서 지도 선택 상태를 설정한다. 500m 반경 검사를 클라이언트 계산에서 제거한다. 알림 팔로우 상태 처리를 알림 데이터 기반으로 변경한다. Changes지도 핀 표시
핀 등록 흐름
지도 장소 이동
알림 상태 표시
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/features/map/hooks/useMapPinOverlays.ts (1)
129-138: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win흐림 상태의 기존 핀 클릭을 차단하세요.
areMapPinsDimmed는 마커 내용에만 전달됩니다.onClick은 흐림 상태에서도 계속 등록됩니다. 또한areMapPinsDimmed변경 시 기존 overlay를 재사용하므로, 마커 DOM을 갱신해도 기존 클릭 핸들러는 남습니다.
src/layouts/PinRegistrationLayout.tsx는 위치 선택 중areMapPinsDimmed를true로 전달합니다. 이 상태에서 기존 핀을 누르면flyTo가 실행됩니다. 지도 중심 변경이onCenterChanged로 이어지면candidateCoordinate도 기존 핀 위치로 바뀔 수 있습니다.흐림 상태를 확인하는 ref로 클릭 핸들러를 조기에 종료하거나, 상태 변경 시 overlay의 클릭 핸들러를 교체 또는 재생성하세요.
MapPinMarker의cursor-pointer도 흐림 상태에서 제거하세요.수정 예시
+ const areMapPinsDimmedRef = useRef(areMapPinsDimmed); + useEffect(() => { + areMapPinsDimmedRef.current = areMapPinsDimmed; + }, [areMapPinsDimmed]); + onClick: () => { + if (areMapPinsDimmedRef.current) return; const latestPin = mapPinsByIdRef.current.get(pin.id);PR 목표의 기존 핀 표시 개선과
src/layouts/PinRegistrationLayout.tsx의 등록 화면 호출 경로를 기준으로 판단했습니다.Also applies to: 164-176
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/features/map/hooks/useMapPinOverlays.ts` around lines 129 - 138, Update the overlay click handling in useMapPinOverlays so clicks on existing pins are ignored while areMapPinsDimmed is true, including overlays reused across dim-state changes; use a ref or replace/recreate handlers to reflect the current state. Also update MapPinMarker to remove cursor-pointer while dimmed, preserving normal click behavior when pins are not dimmed.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@src/features/map/hooks/useMapPinOverlays.ts`:
- Around line 129-138: Update the overlay click handling in useMapPinOverlays so
clicks on existing pins are ignored while areMapPinsDimmed is true, including
overlays reused across dim-state changes; use a ref or replace/recreate handlers
to reflect the current state. Also update MapPinMarker to remove cursor-pointer
while dimmed, preserving normal click behavior when pins are not dimmed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 3ef2d1e1-5689-4b12-a83e-2275308fa85a
📒 Files selected for processing (13)
src/features/map/components/MapPinMarker.tsxsrc/features/map/components/MapViewer.tsxsrc/features/map/hooks/useMapPinOverlays.tssrc/features/map/utils/mapPinMarker.tssrc/features/pin/components/PinPlaceSearch.tsxsrc/layouts/PinRegistrationLayout.tsxsrc/pages/HomePage.tsxsrc/pages/PinLocationConfirmPage.tsxsrc/pages/PinRegisterEntryPage.tsxsrc/pages/PinRegisterPage.tsxsrc/pages/PinRegisterSearchPage.tsxsrc/pages/SongDetailPage.tsxsrc/store/pinCreationStore.ts
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/components/ui/SearchInput.tsx`:
- Line 13: Update the friend variant styling in SearchInput to restore its
existing has-[:focus-visible]:outline-* keyboard-focus classes while preserving
the current background, spacing, and padding classes.
In `@src/pages/MyNotificationsPage.tsx`:
- Around line 108-110: Update the follow-request handling around useToggleFollow
so every memberId mutation receives success processing, rather than relying on
the per-call mutate onSuccess that only reliably applies to the latest call. Use
mutateAsync for each request or move notification-query invalidation into the
hook-level success handler, and track isFollowPending per actor/memberId instead
of exposing only the latest request’s pending state.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 8014a777-494a-4f28-bf6e-560a54021b02
📒 Files selected for processing (9)
src/components/skeletons/HomeSkeleton.tsxsrc/components/ui/SearchInput.tsxsrc/features/map/components/MapPinMarker.tsxsrc/features/map/hooks/useMapPinOverlays.tssrc/features/notification/components/NotificationRow.tsxsrc/features/notification/queries/useNotifications.tssrc/features/notification/types.tssrc/pages/HomePage.tsxsrc/pages/MyNotificationsPage.tsx
🚧 Files skipped from review as they are similar to previous changes (3)
- src/features/map/hooks/useMapPinOverlays.ts
- src/features/map/components/MapPinMarker.tsx
- src/pages/HomePage.tsx
3cacb89 to
604c773
Compare
This branch was successfully deployed
1 participant
변경 내용
핀 등록 QA 동작을 수정합니다.
관련 이슈
Closes #335
변경 사항
테스트
스크린샷 (UI 변경시)
Figma 비교 화면과 라이브 데모로 확인했습니다.
체크리스트
pnpm format)pnpm lint:fix)코드 품질 확인
PR 제출 전에 다음 명령어를 실행하여 코드 품질을 확인해주세요:
Summary by CodeRabbit