feat : 클러스터 범위 수정 및 북마크 UI 연결 - #312
Conversation
클러스터 최종 전환 줌 구간을 6~8/9~10 기준으로 맞추고(NEXT_TIER_ZOOM REGION1 8→9), 지도 북마크 버튼을 눌렀을 때 북마크된 핀/클러스터가 전용 색으로 구분되도록 연결한다. 앨범 커버 없는 핀에 빈 배경색이 안 채워지던 기존 버그도 같이 고친다.
|
Warning Review limit reached
Next review available in: 48 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough지도 핀과 클러스터에 북마크 상태를 추가했습니다. MapPage의 북마크 버튼으로 강조 모드를 토글하면 기존 오버레이의 마커 색상이 갱신됩니다. 클러스터 범위와 빈 커버 표시도 변경했습니다. Changes북마크 지도 강조 표시
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant MapPage
participant MapViewer
participant useMapPinOverlays
participant useClusterOverlays
participant MapPinMarker
participant ClusterMarker
MapPage->>MapViewer: isBookmarkHighlightOn 전달
MapViewer->>useMapPinOverlays: 핀 강조 모드 전달
MapViewer->>useClusterOverlays: 클러스터 강조 모드 전달
useMapPinOverlays->>MapPinMarker: 북마크 핀 색상 갱신
useClusterOverlays->>ClusterMarker: 북마크 클러스터 색상 갱신
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/pages/MapPage.tsx`:
- Line 207: Update the hasBookmarkedPlace value when constructing the
mapFocusPin or focusedFeedPin so it reflects selectedMapPlace.bookmarkedByMe
instead of always being false. Preserve false when the selected place is not
bookmarked.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 13b7eaab-c205-4628-94fb-1f1367983a1e
⛔ Files ignored due to path filters (2)
src/assets/icons/pin-cover-empty.svgis excluded by!**/*.svgsrc/assets/icons/pin.svgis excluded by!**/*.svg
📒 Files selected for processing (12)
src/api/pin.tssrc/features/map/components/ClusterMarker.tsxsrc/features/map/components/MapPinMarker.tsxsrc/features/map/components/MapViewer.tsxsrc/features/map/constants/devMockMapPins.tssrc/features/map/hooks/useClusterOverlays.tssrc/features/map/hooks/useMapPinOverlays.tssrc/features/map/types.tssrc/features/map/utils/mapClusterMarker.tssrc/features/map/utils/mapPinMarker.tssrc/features/pin/components/PinListSheet.tsxsrc/pages/MapPage.tsx
L0521
changed the title
focusedPin의 hasBookmarkedPlace가 항상 false로 고정되어 있어, 북마크된 장소를 검색·피드로 진입해도 강조 모드에서 기본 색으로 표시되던 문제를 수정한다.
This branch was successfully deployed
1 participant
변경 내용
관련 이슈
Closes #301
변경 사항
테스트
스크린샷 (UI 변경시)
체크리스트
pnpm format)pnpm lint:fix)코드 품질 확인
PR 제출 전에 다음 명령어를 실행하여 코드 품질을 확인해주세요:
Summary by CodeRabbit
새 기능
개선