Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paf 160 #133

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Paf 160 #133

wants to merge 3 commits into from

Conversation

shamiluwais
Copy link
Contributor

What?

Mapped and added additional people to the json data that is sent to SQS

Why?

The user is allowed to add unto six additional people to the allegation

How?

Mapped added HOF person field names to IMS field names and added to the json data

Testing?

Tested locally by sending the PAF form allegation to branch SQS and viewing the sent allegation in the Verint IMS PRP1 UI. Similar testing will also be done in branch and UAT.

Copy link
Contributor

@jamiecarterHO jamiecarterHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor things on this one

Comment on lines +9 to +11
eform.Attachements.push({url: fieldValue});
} else if (fieldName === 'tbwhoaddperson') {
eform.AdditionalPeople = fieldValue;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For attachments it needs to be eform.Attachments = fieldValue; here on line 9 as well as with additional people on line 11 otherwise that part of the array is also unnecessarily deep. I think it is that way on master branch right now from #106 or #119.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

basically both lines should be eform.Thing = fieldValue;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants