PAF-74 Allow attachment URLs into SQS payload #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Altered conditionals stopping 'image' array from being added to payload * Fixed a typo * Removed an unnecessary log
TemitopeAyokuHO
approved these changes
Jan 12, 2024
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Altered behaviour as part of form submission to allow file-vault URLs for attachments to be added from the session into the SQS payload and sent to queue.
Removed an unnecessary log of image array. This comes up in other logs elsewhere in the behaviour.
Why?
Existing code was blocking this. Will be a prerequisite to sending the attachment files to IMS from the ims-resolver.
How?
Removed existing conditionals that stopped the array of file-vault URLs for attachements/uploaded files from being brought from the session into the SQS payload.
Altered the tree structure so it will be simpler to extract the file URL array from the payload for processing in the ims-resolver.
Testing?
Tested locally using the UAT queue.