-
-
Notifications
You must be signed in to change notification settings - Fork 584
Add IsVideoUpscaled property to IVideoStreamInfo to detect AI-upscaled streams
#950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
ae347a7
9977318
16096f9
5f7bbee
0e150f2
fa0fe12
d83b7ad
33d426b
8852ed6
22d6ef4
71f0907
5ec2327
d346d11
d4bcbc1
f4ec180
95a43d5
9ed7b5c
aa6032f
3a76e4e
ff35cf0
94539a8
53207b7
bccda04
f55b58a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -17,7 +17,8 @@ public class MuxedStreamInfo( | |||||||||||||||||||||||||||||||||||||||||||||||||||||||
| bool? isAudioLanguageDefault, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| string videoCodec, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| VideoQuality videoQuality, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Resolution videoResolution | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Resolution videoResolution, | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| bool isUpscaled | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Owner
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Rename all instances to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in d346d11. Renamed |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| ) : IAudioStreamInfo, IVideoStreamInfo | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { | |
| { | |
| public MuxedStreamInfo( | |
| string url, | |
| Container container, | |
| FileSize size, | |
| Bitrate bitrate, | |
| string audioCodec, | |
| Language? audioLanguage, | |
| bool? isAudioLanguageDefault, | |
| string videoCodec, | |
| VideoQuality videoQuality, | |
| Resolution videoResolution | |
| ) | |
| : this( | |
| url, | |
| container, | |
| size, | |
| bitrate, | |
| audioCodec, | |
| audioLanguage, | |
| isAudioLanguageDefault, | |
| videoCodec, | |
| videoQuality, | |
| videoResolution, | |
| false | |
| ) { } |
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -13,7 +13,8 @@ public class VideoOnlyStreamInfo( | |||||
| Bitrate bitrate, | ||||||
| string videoCodec, | ||||||
| VideoQuality videoQuality, | ||||||
| Resolution videoResolution | ||||||
| Resolution videoResolution, | ||||||
| bool isUpscaled | ||||||
|
||||||
| bool isUpscaled | |
| bool isUpscaled = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot let's add a constructor overload that sets this to false for backwars compat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 94539a8. Added backwards-compatible overloads to both VideoOnlyStreamInfo and MuxedStreamInfo that omit isVideoUpscaled and delegate to the primary constructor with false.
Uh oh!
There was an error while loading. Please reload this page.