Conversation
Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeExplode/sessions/0842c42c-6dc5-4fac-bb5f-84ad15684dcb Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
IsUpscaled property to VideoQuality to detect AI-upscaled streams
|
@copilot tests are failing. Are you sure If I had to guess, the new metadata should be inside the player response. Try changing the code to dump the response to a file and analyze it to find if there's anything related to upscaling, super-resolution, or AI enhansion. |
…ity label Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeExplode/sessions/e92f9c9f-22f9-48c0-b658-938b09d39917 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
…m constructor Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeExplode/sessions/e92f9c9f-22f9-48c0-b658-938b09d39917 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
You were right — the quality label stays plain (e.g. Fixed in fa0fe12: Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…ntations Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeExplode/sessions/26b14d21-cf36-47a0-be4d-5eef6f9e3eb1 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
IsUpscaled property to VideoQuality to detect AI-upscaled streamsIsUpscaled property to IVideoStreamInfo to detect AI-upscaled streams
…mentations Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeExplode/sessions/fc7c7e86-ffe9-4842-b400-a9a5b545b736 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
…ns instead of out params Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeExplode/sessions/c011fa5e-1d9d-4e03-9607-560eef765e07 Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeExplode/sessions/35a1c857-b109-4038-9bc4-5a31d76d3caa Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
… and MuxedStreamInfo Agent-Logs-Url: https://github.com/Tyrrrz/YoutubeExplode/sessions/37203393-1071-48ff-908c-202989cff48f Co-authored-by: Tyrrrz <1935960+Tyrrrz@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## prime #950 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
IsVideoUpscaledfromVideoQualitytoIVideoStreamInfoand its implementationsUtils.ProtobufreturningIReadOnlyDictionary<string, string?>TryDeserialize→TryDeserializeMapto make intent clearTryReadVarintandTryReadStringto return nullable values instead ofoutparams +boolTryReadVarint+TryDeserializeMap(byte[])appear before the callerTryDeserializeMap(string)GetValueOrDefaultinstead ofTryGetValueinPlayerResponseIsLenField(ulong tag)helper for wire-type 2 checks inProtobufTryReadStringhelper for string field reading inProtobufvareverywhere inProtobuf.csIsUpscaled→IsVideoUpscaledinIVideoStreamInfo,VideoOnlyStreamInfo,MuxedStreamInfo, and testsVideoQuality.FromItag(back to 2-param constructor)IsVideoUpscaledto afterVideoHeight(and beforeVideoFramerate) inIStreamData,PlayerResponse.StreamData, andDashManifest.StreamData; already afterVideoResolutioninIVideoStreamInfo,VideoOnlyStreamInfo, andMuxedStreamInfoVideoOnlyStreamInfoandMuxedStreamInfo(withoutisVideoUpscaled, defaulting tofalse)