test: restore global mock isolation

[jatmn]

Summary

• restore the real provider-startup module after ProviderManager tests
• remove attribution's process-global governance mock and restore its model mocks
• restore real settings, config, registry, and analytics modules after sponsored-tip tests
• import the provider-startup module under a nonce so its regression test is independent of prior test mocks

Scope

Targets four serial smoke-test isolation defects only. This does not overlap #1978 or #1979.

Validation

• bun test --feature=UNATTENDED_RETRY src/components/ProviderManager.test.tsx src/utils/providerStartupOverrides.test.ts src/utils/attribution.test.ts src/services/tips/sponsoredTips.test.ts src/services/tips/tipScheduler.test.ts
• bun run smoke
• git diff --check

Reviewed AGENTS.md and CONTRIBUTING.md.

Summary by CodeRabbit

• Tests
  • Improved test isolation and cleanup across provider, settings, configuration, analytics, attribution, and sponsored tips test suites.
  • Ensured mocked modules are reliably restored to their real implementations after tests complete.
  • Updated provider override tests to load fresh module instances and verify stale environment settings are cleared.

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

Test module isolation

Layer / File(s)	Summary
Dynamic loading of real modules src/components/ProviderManager.test.tsx, src/utils/providerStartupOverrides.test.ts	Provider-related tests dynamically load real modules with cache-busting imports and restore captured implementations during cleanup.
Tips suite module teardown src/services/tips/sponsoredTips.test.ts, src/services/tips/tipScheduler.test.ts	Tips tests explicitly re-bind real config, settings, analytics, and tip registry modules after restoring mocks.
Attribution module restoration src/utils/attribution.test.ts	Attribution tests remove the governance policy stub and restore model, provider, and settings modules during teardown.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

• Gitlawb/openclaude#1806: Updates governance-policy mocking and restoration in the attribution tests.

Suggested labels: bug

Suggested reviewers: kevincodex1, techbrewboss

🚥 Pre-merge checks | ✅ 7

✅ Passed checks (7 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Risk Surface Disclosed	✅ Passed	PASS: The patch only changes test isolation files; no auth/provider-routing/startup production code was modified, so no risk-surface blocker is needed.
No Hidden Policy Change	✅ Passed	Commit only touches five test files, and hunks are mock reset/import cleanup; no runtime policy, routing, telemetry, or permission code changed.
Title check	✅ Passed	Concise and accurately describes the test-only mock-isolation fixes in the diff.
Description check	✅ Passed	Covers summary, scope, and validation clearly; Impact and Notes sections are omitted but the core template is complete.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[jatmn]

@kevincodex1 LGTM