test: isolate flaky smoke assertions

[jatmn]

Summary

• isolate the plan-mode legacy-reminder assertion from leaked feature-flag state
• restore the real provider module around domain-check tests while preserving OpenAI/Gemini classification coverage

Validation

• bun test --feature=UNATTENDED_RETRY src/tools/WebFetchTool/domainCheck.test.ts src/utils/messages/planMode.test.ts --rerun-each 20
• bun run smoke
• bun run test:full (scoped tests no longer fail; existing unrelated environment/baseline failures remain)

Final reviewed SHA: 1743c5c

Summary by CodeRabbit

• Tests
  • Improved test isolation for domain access checks and plan mode behavior.
  • Prevented environment settings and feature flags from leaking between tests.
  • Ensured provider behavior is reset consistently after each test.

[coderabbitai]

📝 Walkthrough

Walkthrough

Changes

The test updates isolate provider module mocks in domain blocklist tests and isolate plan-mode environment and shared mutation state across tests.

Test isolation

Layer / File(s)	Summary
Provider mock lifecycle src/tools/WebFetchTool/domainCheck.test.ts	Dynamic provider imports and centralized cleanup replace per-test provider-selection mocks for OpenAI, Gemini, and first-party cases.
Plan-mode lifecycle isolation src/utils/messages/planMode.test.ts	Tests acquire the shared mutation lock, pin the interview-phase environment variable, and restore state during cleanup.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

• Gitlawb/openclaude#1959: Updates related shared mutation lock and test-state restoration infrastructure.

Suggested labels: bug

Suggested reviewers: kevincodex1

🚥 Pre-merge checks | ✅ 6 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Risk Surface Disclosed	⚠️ Warning	PR touches provider-routing test code, but the description only covers isolation/validation and never explicitly flags the routing risk surface or whether it’s a blocker.	Add a maintainer note stating the change is test-only, provider-routing behavior is unchanged, and no blocker/risk was introduced.

✅ Passed checks (6 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
No Hidden Policy Change	✅ Passed	PASS: HEAD only changes two test files to isolate flaky state; no product, trust, routing, telemetry/network, or permission-policy code changes are hidden.
Title check	✅ Passed	The title is concise and matches the diff’s focus on isolating flaky test assertions.
Description check	✅ Passed	The description covers the summary and testing, but it omits the Impact and Notes sections from the template.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[jatmn]

@kevincodex1 LGTM
1 of probably many.

[kevincodex1]

nice one!

[devNull-bootloader]

@coderabbitai why are PR checks failing

[coderabbitai]

CodeRabbit chat interactions are restricted to organization members for this repository. Ask an organization member to interact with CodeRabbit, or set chat.allow_non_org_members: true in your configuration.