fix(typecheck): declare Ink JSX intrinsics - #1571
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used📓 Path-based instructions (3)**/*.{ts,tsx,js,jsx,py}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*⚙️ CodeRabbit configuration file
Files:
**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (4)
📝 WalkthroughWalkthroughThis PR strengthens TypeScript type safety for Ink JSX intrinsic elements by replacing generic ChangesInk JSX Intrinsic Element Typing
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 6 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jatmn
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I do not see any actionable issues from my review.
@kevincodex1 LGTM
Summary
Addresses part of #1486 by declaring the custom Ink host elements used by the internal renderer.
react-jsxruntimeink-linkandink-raw-ansiin addition to the existing Ink host nodesink-box/ink-textprops lightweight types based on the existing Ink DOM, style, and event typesDuplicate PR check
Checked all open PR files in
Gitlawb/openclaudebefore opening this branch. The only nearby overlap was #1562 onsrc/global.d.ts; this branch editssrc/ink/global.d.tsand handles a separate Ink JSX intrinsic-element cluster.Validation
Ran
bun run typecheckon this branch.src/diagnostics: 1043 -> 1032Summary by CodeRabbit