fix: skip assertMinVersion for third-party providers - #123
Merged
kevincodex1 merged 1 commit intoApr 2, 2026
Merged
Conversation
The version kill-switch calls Anthropic's GrowthBook endpoint to enforce a minimum version. This is currently safe for 3P users only because isAnalyticsDisabled() returns true (disabling GrowthBook). Adding an explicit provider guard makes this safety independent of the analytics stub, preventing 3P users from being blocked by Anthropic's version requirements in case of future upstream merges.
auriti
force-pushed
the
fix/assert-min-version-provider-guard
branch
from
April 2, 2026 09:09
7c33c86 to
6c4225f
Compare
kevincodex1
approved these changes
Apr 2, 2026
euxaristia
pushed a commit
to euxaristia/openclaude
that referenced
this pull request
Apr 13, 2026
…ovider-guard fix: skip assertMinVersion for third-party providers
reymaster
pushed a commit
to reymaster/openclaude
that referenced
this pull request
May 5, 2026
…ovider-guard fix: skip assertMinVersion for third-party providers
This was referenced Jun 4, 2026
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
getAPIProvider() !== 'firstParty'guard toassertMinVersion()inautoUpdater.tsProblem
assertMinVersion()calls Anthropic's GrowthBook endpoint to enforce a minimum version. This is currently safe for 3P (OpenAI/Gemini/Ollama) users only becauseisAnalyticsDisabled()returnstrue, which disables GrowthBook. But this safety depends on a single stub function — if an upstream merge ever changes it, 3P users would be subject to Anthropic's version kill-switch.Adding an explicit provider guard makes the safety independent of the analytics stub.
Relates to #115
Test plan
assertMinVersion()exits early whenCLAUDE_CODE_USE_OPENAI=1