fix(typecheck): add plugin command view types - #1565
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📜 Recent review details⏰ Context from checks skipped due to timeout of 900000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🧰 Additional context used📓 Path-based instructions (3)**/*.{ts,tsx,js,jsx,py}📄 CodeRabbit inference engine (CONTRIBUTING.md)
Files:
**/*⚙️ CodeRabbit configuration file
Files:
**⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (1)
📝 WalkthroughWalkthroughThis PR strengthens TypeScript type safety across the plugin management UI by introducing new public type definitions and refactoring components to use explicit types for state, intermediate records, and exported signatures. ChangesPlugin Type System
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/commands/plugin/ManagePlugins.tsx`:
- Around line 1514-1523: The code creates a local variable enabledPlugins and
then redundantly spreads it into the object passed to updateSettingsForSource;
change the call to updateSettingsForSource('localSettings', { enabledPlugins:
enabledPlugins }) (i.e., pass the enabledPlugins record directly) instead of
using {...enabledPlugins}; locate enabledPlugins, updateSettingsForSource,
getSettingsForSource and pluginId_8 in ManagePlugins.tsx to make this simple
substitution.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 2824b5c1-fe63-4ca8-b3f9-bb8218d327db
📒 Files selected for processing (5)
src/commands/plugin/ManagePlugins.tsxsrc/commands/plugin/PluginSettings.tsxsrc/commands/plugin/UnifiedInstalledCell.tsxsrc/commands/plugin/types.tssrc/commands/plugin/unifiedTypes.ts
📜 Review details
🧰 Additional context used
📓 Path-based instructions (3)
**/*.{ts,tsx,js,jsx,py}
📄 CodeRabbit inference engine (CONTRIBUTING.md)
**/*.{ts,tsx,js,jsx,py}: Follow the existing code style in the touched files
Keep comments useful and concise
Files:
src/commands/plugin/types.tssrc/commands/plugin/UnifiedInstalledCell.tsxsrc/commands/plugin/unifiedTypes.tssrc/commands/plugin/PluginSettings.tsxsrc/commands/plugin/ManagePlugins.tsx
**/*
⚙️ CodeRabbit configuration file
**/*: Apply the OpenClaude maintainer review rubric from AGENTS.md. Review the current diff, not stale discussion context. Separate real blockers from suggestions. Do not request changes for vague style churn. Treat approval as merge-ready from CodeRabbit's side, pending required human review and GitHub Checks. If checks are failing or unavailable, say so clearly instead of implying the PR is fully ready.
Files:
src/commands/plugin/types.tssrc/commands/plugin/UnifiedInstalledCell.tsxsrc/commands/plugin/unifiedTypes.tssrc/commands/plugin/PluginSettings.tsxsrc/commands/plugin/ManagePlugins.tsx
**
⚙️ CodeRabbit configuration file
**: # Contributing to OpenClaudeThanks for contributing.
OpenClaude is a fast-moving open-source coding-agent CLI with support for multiple providers, local backends, MCP, and a terminal-first workflow. The best contributions here are focused, well-tested, and easy to review.
Before You Start
- Search existing issues and discussions before opening a new thread.
- Check open pull requests for work that overlaps with your contribution. If a PR already exists that addresses the same change, open an issue or discussion first to align on direction — duplicate PRs may be closed without review.
- Use issues for confirmed bugs and actionable feature work.
- Use discussions for setup help, ideas, and general community conversation.
- For larger changes, open an issue first so the scope is clear before implementation.
- For security reports, follow SECURITY.md.
Pull Requests
Every PR needs a reason. Your PR description must include:
- what changed and why
- the user or developer impact
- the exact checks you ran
- a linked issue when one exists, using
Fixes#123, `Closes `#123, or another clear link- screenshots when the PR touches UI, terminal presentation, or the VS Code extension
- which provider path was tested when the PR changes provider behavior
The PR author is responsible for ensuring their PR is merge-ready. PRs with merge conflicts will not be reviewed or approved until the conflicts are resolved.
Issues are the recommended starting point for anything non-trivial — opening one first helps avoid wasted effort if the change is out of scope or already being worked on. Small fixes, doc corrections, and obvious improvements can stand on their own without a linked issue, as long as the PR description explains the intent.
What Gets Closed Without Review
PRs may be closed without review...
Files:
src/commands/plugin/types.tssrc/commands/plugin/UnifiedInstalledCell.tsxsrc/commands/plugin/unifiedTypes.tssrc/commands/plugin/PluginSettings.tsxsrc/commands/plugin/ManagePlugins.tsx
🔇 Additional comments (6)
src/commands/plugin/types.ts (1)
1-36: LGTM!src/commands/plugin/unifiedTypes.ts (1)
1-59: LGTM!src/commands/plugin/PluginSettings.tsx (1)
31-39: LGTM!Also applies to: 348-348, 366-385, 737-770, 989-1003
src/commands/plugin/ManagePlugins.tsx (2)
239-313: LGTM!
1471-1478: LGTM!src/commands/plugin/UnifiedInstalledCell.tsx (1)
11-11: LGTM!
jatmn
left a comment
jatmn
left a comment
There was a problem hiding this comment.
Thanks for the contribution. I do not see any actionable issues from my review.
@kevincodex1 LGTM
* fix(typecheck): add plugin command view types * fix(typecheck): simplify plugin settings update
3 participants
Refs #1486
Summary
ViewStateandPluginSettingsPropstypes used by the plugin command viewsUnifiedInstalledItemunion for installed plugin/MCP rowsnever[]ornulltoo tightlyValidation
bun run typecheckstill fails on unrelated baseline errors from fix: (All-call) TypeScript cleanup PRs needed #1486src/*diagnostics reduced from 1043 to 1011 versus the captured baselineDuplicate check
ManagePlugins.tsximporting../../components/mcp/types.js, which is covered separately by fix(typecheck): add MCP component view types #1564.Summary by CodeRabbit