Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make drop target for uploads functional across entire range #21681

Closed
wants to merge 3 commits into from

Conversation

harshul786
Copy link

Description of Change

This PR addresses the issue [#21439](#21439), where the drop target for uploads was inconsistent and did not cover the full range of the drop area.

Changes made:

  • Added w-full and h-full classes to the drop component of the FileUpload drag-and-drop.
  • Removed unnecessary padding that created non-functional areas within the drop target.

Use Case

The change ensures that the entire designated area for uploads functions correctly as a drop target, improving the user experience and fixing the reported bug.

@cathysarisky
Copy link
Contributor

cathysarisky commented Nov 21, 2024

I'm sorry to report that this does not solve the problem. See details here: #21687

@9larsons
Copy link
Contributor

Thanks for the submission. This seems to foul up the visual indicator that you're over the drop. We're working on a similar fix that's for more than just the migrations dropdown, so I'm going to close this out, but it should be resolved fairly soon.

@9larsons 9larsons closed this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants