Drop target for uploads (content and theme) is broken.

[cathysarisky]

Issue Summary

(Not a new issue - has been bugging me for months!)

The 'drop target' for drag and dropping a theme or upload file doesn't work right on Windows 10, Chrome browser. Occurs on local installs AND on Ghost Pro.

Image: Shows hovering over the 'drop area', but the cursor still shows 'copy', and if I drop it here, it'll download it (NOT upload it to Ghost).

Image: The very edge of the drop area (marked in yellow) is actually droppable. /IF/ I can get my cursor over this sliver between the dotted and solid borders, dropping works. The big red x area is not.

Chrome is up to date:
Version 130.0.6723.70 (Official Build) (64-bit)

UPDATE: See #21687 for more discussion . I think this is not actually a problem with the drop area, but with re-rendering. (Holding the mouse still for a long period seems to stop the rerenders, and targeting the edge was probably causing me to do that? I think?)

Steps to Reproduce

Use Chrome. (Possibly use Chrome on Windows - not sure.)
Attempt to drag and drop a file into the drop area for theme upload or import upload.

I expect the entire box to be a valid drop target.

Ghost Version

5.98 (and multiple versions before)

Node.js Version

18

How did you install Ghost?

various, including on Ghost Pro

Database type

MySQL 8

Browser & OS version

Chrome Version 130.0.6723.70 (Official Build) (64-bit)

Relevant log / error output

No response

Code of Conduct

• I agree to be friendly and polite to people in this repository

[aarifkhan7]

Hey @cathysarisky,

I'm a beginner interested in contributing to open source, and this issue seems like a good starting point for me. Could you please assign it to me?

Thanks!

[cathysarisky]

I'm a beginner interested in contributing to open source, and this issue seems like a good starting point for me. Could you please assign it to me?

Sorry, I don't have write-permissions on this repo so can't help you there. The Ghost dev team has said previously that they don't assign issues to new contributors, but you're welcome to put in a PR for it.

If you're currently using Ghost, you might like to head on over to the forum (https://forum.ghost.org) and introduce yourself, too!

[aarifkhan7]

It's fine, I will create a PR.

Thanks for the forum link, I will join it. :)

[9larsons]

That's correct, we do not assign issues. If you want to fix it, just open a PR 👍.

[harshul786]

Submitted a PR to resolve this: #21440. Hope it helps—happy to tweak if needed! 🙌