-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version Tick v0.0.0 => v0.0.1 #56
Conversation
So, you want us to release toxcore 0.1.0 now, while being halfway done with #40? Sounds like a bad idea. |
|
Missed that |
the library version is set in configure.ac. what are you trying to achieve with the preprocessor defines? the linker/loader will not see them. (yes the interface version should have been incremented some time ago, also the package version...) EDIT: see http://ftp.gnu.org/old-gnu/Manuals/libtool-1.4.2/html_node/libtool_34.html for an explanation. the relevant section has already been been pasted into configure.ac. |
@felix-salfelder I dont care about linker/loaders, the macro changed above are convenience macros for compiling with clients. Also, see my previous comment as to the reason I want this change. It's purely for speaking convenience. |
GrayHatter wrote
that's fine, you don't need to. linkers and loaders aside, the version is (and hopefully will remain) written down in configure.ac, which you missed to update in this PR. imo convenience macros should be synchronized with actual versions, that's why i was wondering. nurupo wrote
that makes sense. let me suggest to release 0.0.0 before 0.1.0... (regardless of #40). but: are there any release plans at all? and which project or developer would be in charge then? thanks |
@felix-salfelder there's no such thing as version v0.0.0 in toxcore. If you have your heart set on getting a v0.0.0 release, you'd have to ask @irungentoo and I assume he'll point you to https://github.com/irungentoo/toxcore/archive/master.tar.gz |
ee09635
to
fd30c99
Compare
i have not invented the way software is being packaged and distributed. this thread, indicates that releases will also help your own client development, go figure.
i did, see irungentoo#1610. there you replied "[..] not likely [t]here", but without explanation. you seem to be more active, but are you a tox (as in toxcore, tox "the library") developer at all? |
e4e1f3e
to
8ab7cad
Compare
Can you rebase this, and look around to make sure you caught all the places (cmake, configure, code) where 0.0.0 needs to be updated to 0.1.0? |
8ab7cad
to
b869edf
Compare
@iphydf done |
Changed from |
83fae5a
to
b9e1fa9
Compare
With the API change (making the callbacks stateless), TokTok/toxcore has diverged enough from irungentoo/toxcore that at the very least the minor version number needs to be incremented. Remaining on v0.0.0 is harmful to both clients/client developers, and package maintainers.
b9e1fa9
to
89bdc3a
Compare
This will update tox.in.h only. Currently, you will still need to manually update tox.h. An upcoming PR (irungentoo#154) will update tox.h as part of the build.
this too WAY more time then it should have
Can you remove all the scripts and just change the versions? Perhaps for the LT_VERSION you can use the version components (if autoconf provides those) so we have one less place to update. |
new API functions to show network connections
With the API change (making the callbacks stateless), TokTok/toxcore has
diverged enough from irungentoo/toxcore that at the very least the minor version
number needs to be incremented. Remaining on v0.0.0 is harmful to both
clients/client developers, and package maintainers.
This change is NOT reviewable. Use Github reviews instead.