Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Tick v0.0.0 => v0.0.1 #56

Closed
wants to merge 4 commits into from

Conversation

GrayHatter
Copy link

@GrayHatter GrayHatter commented Aug 20, 2016

With the API change (making the callbacks stateless), TokTok/toxcore has
diverged enough from irungentoo/toxcore that at the very least the minor version
number needs to be incremented. Remaining on v0.0.0 is harmful to both
clients/client developers, and package maintainers.


This change is NOT reviewable. Use Github reviews instead.

@nurupo
Copy link
Member

nurupo commented Aug 21, 2016

So, you want us to release toxcore 0.1.0 now, while being halfway done with #40? Sounds like a bad idea.

@GrayHatter
Copy link
Author

<grayhatter> I want to be able to say v0.0 vs v0.1
<grayhatter> (reason for that pull)
<iphy> let's do that when stateless is done
<grayhatter> tux3 nurupo iphy
<grayhatter> do you want me to close it, or leave it open and rebase when stateless is done?
<tux3> I'd leave it open, just because I've been promised toxcore versionning for so long, and as far as I'm concerned the sooner the better!
<iphy> leave it open

@nurupo
Copy link
Member

nurupo commented Aug 21, 2016

Missed that

@felix-salfelder
Copy link

felix-salfelder commented Aug 21, 2016

the library version is set in configure.ac. what are you trying to achieve with the preprocessor defines? the linker/loader will not see them.

(yes the interface version should have been incremented some time ago, also the package version...)

EDIT: see http://ftp.gnu.org/old-gnu/Manuals/libtool-1.4.2/html_node/libtool_34.html for an explanation. the relevant section has already been been pasted into configure.ac.

@GrayHatter
Copy link
Author

@felix-salfelder I dont care about linker/loaders, the macro changed above are convenience macros for compiling with clients. Also, see my previous comment as to the reason I want this change. It's purely for speaking convenience.

@felix-salfelder
Copy link

GrayHatter wrote

I dont care about linker/loaders

that's fine, you don't need to. linkers and loaders aside, the version is (and hopefully will remain) written down in configure.ac, which you missed to update in this PR. imo convenience macros should be synchronized with actual versions, that's why i was wondering.

nurupo wrote

So, you want us to release toxcore 0.1.0 now, while being halfway done with #40? Sounds like a bad idea

that makes sense. let me suggest to release 0.0.0 before 0.1.0... (regardless of #40). but: are there any release plans at all? and which project or developer would be in charge then?

thanks

@GrayHatter
Copy link
Author

@felix-salfelder there's no such thing as version v0.0.0 in toxcore. If you have your heart set on getting a v0.0.0 release, you'd have to ask @irungentoo and I assume he'll point you to https://github.com/irungentoo/toxcore/archive/master.tar.gz

@felix-salfelder
Copy link

If you have your heart set on getting a v0.0.0 release

i have not invented the way software is being packaged and distributed. this thread, indicates that releases will also help your own client development, go figure.

you'd have to ask @irungentoo

i did, see irungentoo#1610. there you replied "[..] not likely [t]here", but without explanation. you seem to be more active, but are you a tox (as in toxcore, tox "the library") developer at all?

@GrayHatter GrayHatter force-pushed the version_tick branch 3 times, most recently from e4e1f3e to 8ab7cad Compare September 11, 2016 21:04
@iphydf
Copy link
Member

iphydf commented Sep 21, 2016

Can you rebase this, and look around to make sure you caught all the places (cmake, configure, code) where 0.0.0 needs to be updated to 0.1.0?

@GrayHatter
Copy link
Author

@iphydf done

@GrayHatter GrayHatter changed the title Version Tick v0.0.0 => v0.1.0 Version Tick v0.0.0 => v0.0.1 Sep 23, 2016
@GrayHatter
Copy link
Author

Changed from v0.1.0 to v0.0.1

With the API change (making the callbacks stateless), TokTok/toxcore has
diverged enough from irungentoo/toxcore that at the very least the minor version
number needs to be incremented. Remaining on v0.0.0 is harmful to both
clients/client developers, and package maintainers.
iphydf and others added 3 commits September 23, 2016 23:34
This will update tox.in.h only. Currently, you will still need to
manually update tox.h. An upcoming PR (irungentoo#154) will update tox.h as
part of the build.
this too WAY more time then it should have
@iphydf
Copy link
Member

iphydf commented Sep 24, 2016

Can you remove all the scripts and just change the versions? Perhaps for the LT_VERSION you can use the version components (if autoconf provides those) so we have one less place to update.

@iphydf iphydf closed this Sep 29, 2016
@iphydf iphydf modified the milestone: v0.0.1 Nov 6, 2016
@GrayHatter GrayHatter deleted the version_tick branch November 19, 2016 07:18
zoff99 added a commit to Zoxcore/_c-toxcore_old_backup that referenced this pull request Dec 24, 2022
new API functions to show network connections
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants